Disable incremental linking for gn osmesa

Disable incremental linking for gn osmesa

Due to a VS 2015 linker bug the linker sometimes crashes when
incrementally linking osmesa.dll. The bug is understood by Microsoft and
will be fixed but while waiting for the fix it would be nice to avoid
the crash.

This disables incremental linking for gn builds only. I could not get
disabling for gyp builds to work so this is a partial fix. gn FTW!

BUG=440500, 482671
Committed: https://crrev.com/ebdb684a77d95889be31d09df5973297ca4decce
Cr-Commit-Position: refs/heads/master@{#383420}

[brucedawson, 2016-03-25 21:40:54]

brucedawson@chromium.org changed reviewers:
+ jam@chromium.org

[brucedawson, 2016-03-25 21:40:55]

This will avoid osmesa linker crashes on gn builds. I don't know why the
disabling of incremental linking doesn't work on gyp builds - either I'm doing
something wrong or else msvs_debug_link_incremental doesn't work.

Try it locally? And if you have any gyp thoughts let me know.

[brucedawson, 2016-03-25 21:47:05]

Adding thakis@ since he was also hitting crashes and may know what is wrong with
the gyp version.

[jam, 2016-03-25 22:34:03]

lgtm

[brucedawson, 2016-03-25 22:44:30]

On 2016/03/25 22:34:03, jam wrote:
> lgtm

Any idea why the gyp variant doesn't work? I could always check in the .gn
variant only, or see if scottmg@ knows.

[brucedawson, 2016-03-25 23:06:52]

scottmg@ - any idea why the gyp version of this is failing to disable
incremental linking? Am I using the feature wrong or is it broken?

[brucedawson, 2016-03-26 00:00:20]

Description was changed from

==========
Disable incremental linking for osmesa

Due to VS 2015 linker bug the linker sometimes crashes when
incrementally linking osmesa.dll. The bug is understood by Microsoft and
will be fixed but while waiting for the fix it would be nice to avoid
the crash.

The disabling for gn builds works but the disabling for gyp builds does
not - I don't know why.

BUG=440500,482671
==========

to

==========
Disable incremental linking for gn osmesa

Due to a VS 2015 linker bug the linker sometimes crashes when
incrementally linking osmesa.dll. The bug is understood by Microsoft and
will be fixed but while waiting for the fix it would be nice to avoid
the crash.

This disables incremental linking for gn builds only. I could not get
disabling for gyp builds to work so this is a partial fix. gn FTW!

BUG=440500,482671
==========

[brucedawson, 2016-03-26 00:00:44]

On 2016/03/25 23:06:52, brucedawson wrote:
> scottmg@ - any idea why the gyp version of this is failing to disable
> incremental linking? Am I using the feature wrong or is it broken?

For now I've removed the non-functional gyp fix and updated the description.
Landing the gn fix seems worthwhile.

[brucedawson, 2016-03-26 00:00:48]

The CQ bit was checked by brucedawson@chromium.org

[brucedawson, 2016-03-26 00:00:49]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org
Link to the patchset: https://codereview.chromium.org/1833263002/#ps20001
(title: "Remove non-working gyp fix")

[commit-bot: I haz the power, 2016-03-26 00:01:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1833263002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1833263002/20001

[jam, 2016-03-26 00:05:20]

no idea, I only use gn at this point

On Fri, Mar 25, 2016 at 3:44 PM, <brucedawson@chromium.org> wrote:

> On 2016/03/25 22:34:03, jam wrote:
> > lgtm
>
> Any idea why the gyp variant doesn't work? I could always check in the .gn
> variant only, or see if scottmg@ knows.
>
> https://codereview.chromium.org/1833263002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2016-03-26 00:38:44]

Description was changed from

==========
Disable incremental linking for gn osmesa

Due to a VS 2015 linker bug the linker sometimes crashes when
incrementally linking osmesa.dll. The bug is understood by Microsoft and
will be fixed but while waiting for the fix it would be nice to avoid
the crash.

This disables incremental linking for gn builds only. I could not get
disabling for gyp builds to work so this is a partial fix. gn FTW!

BUG=440500,482671
==========

to

==========
Disable incremental linking for gn osmesa

Due to a VS 2015 linker bug the linker sometimes crashes when
incrementally linking osmesa.dll. The bug is understood by Microsoft and
will be fixed but while waiting for the fix it would be nice to avoid
the crash.

This disables incremental linking for gn builds only. I could not get
disabling for gyp builds to work so this is a partial fix. gn FTW!

BUG=440500,482671
==========

[commit-bot: I haz the power, 2016-03-26 00:38:45]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-26 00:41:52]

Description was changed from

==========
Disable incremental linking for gn osmesa

Due to a VS 2015 linker bug the linker sometimes crashes when
incrementally linking osmesa.dll. The bug is understood by Microsoft and
will be fixed but while waiting for the fix it would be nice to avoid
the crash.

This disables incremental linking for gn builds only. I could not get
disabling for gyp builds to work so this is a partial fix. gn FTW!

BUG=440500,482671
==========

to

==========
Disable incremental linking for gn osmesa

Due to a VS 2015 linker bug the linker sometimes crashes when
incrementally linking osmesa.dll. The bug is understood by Microsoft and
will be fixed but while waiting for the fix it would be nice to avoid
the crash.

This disables incremental linking for gn builds only. I could not get
disabling for gyp builds to work so this is a partial fix. gn FTW!

BUG=440500,482671

Committed: https://crrev.com/ebdb684a77d95889be31d09df5973297ca4decce
Cr-Commit-Position: refs/heads/master@{#383420}
==========

[commit-bot: I haz the power, 2016-03-26 00:41:53]

Patchset 2 (id:??) landed as
https://crrev.com/ebdb684a77d95889be31d09df5973297ca4decce
Cr-Commit-Position: refs/heads/master@{#383420}

[scottmg, 2016-03-29 17:03:42]

scottmg@chromium.org changed reviewers:
+ scottmg@chromium.org

[scottmg, 2016-03-29 17:03:43]

https://codereview.chromium.org/1833263002/diff/1/third_party/mesa/mesa.gyp
File third_party/mesa/mesa.gyp (right):

https://codereview.chromium.org/1833263002/diff/1/third_party/mesa/mesa.gyp#n...
third_party/mesa/mesa.gyp:694: 'msvs_debug_link_incremental': '1',
I don't know what that variable is supposed to do. I think you want
msvs_settings>VCLinkerTool>LinkIncremental: 1.