Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 1833243002: Remove CreateRenderFrameFlags enum. (Closed)

Created:
4 years, 9 months ago by nasko
Modified:
4 years, 9 months ago
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove CreateRenderFrameFlags enum. The CreateRenderFrameFlags enum currently has only one value, which can easily be replaced by a boolean. This CL is removing this enum in favor of a bool value. BUG=357747 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/259799c180b8571c05473c0111f3e1fbf0e978ee Cr-Commit-Position: refs/heads/master@{#383401}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -36 lines) Patch
M content/browser/frame_host/render_frame_host_factory.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/frame_host/render_frame_host_factory.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.h View 2 chunks +1 line, -7 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 2 chunks +1 line, -2 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager.cc View 7 chunks +7 lines, -17 lines 0 comments Download
M content/test/test_render_frame_host_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M content/test/test_render_frame_host_factory.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
nasko
Hey Lukasz, Can you review this CL for me? It converts an enum with one ...
4 years, 9 months ago (2016-03-25 21:38:41 UTC) #3
Łukasz Anforowicz
LGTM
4 years, 9 months ago (2016-03-25 21:49:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1833243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1833243002/1
4 years, 9 months ago (2016-03-25 21:56:55 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-25 23:17:14 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-25 23:18:54 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/259799c180b8571c05473c0111f3e1fbf0e978ee
Cr-Commit-Position: refs/heads/master@{#383401}

Powered by Google App Engine
This is Rietveld 408576698