Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 18332026: Add UseCounter entry for SVGAnimationElement (Closed)

Created:
7 years, 5 months ago by pdr.
Modified:
7 years, 5 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, pdr, f(malita), dglazkov+blink, eae+blinkwatch, Stephen Chennney
Visibility:
Public.

Description

Add UseCounter entry for SVGAnimationElement This patch adds a UseCounter to SVG's animation elements for measuring SMIL usage. In a future patch we may add UseCounter entries for more granular elements (SVGAnimateElement, SVGSetElement, etc) but to reduce churn just SVGAnimationElement is being measured here. BUG=258298 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154026

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M Source/core/page/UseCounter.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGAnimationElement.cpp View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
pdr.
7 years, 5 months ago (2013-07-11 05:29:52 UTC) #1
abarth-chromium
lgtm
7 years, 5 months ago (2013-07-11 05:31:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/18332026/1
7 years, 5 months ago (2013-07-11 05:33:37 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=12844
7 years, 5 months ago (2013-07-11 07:54:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/18332026/1
7 years, 5 months ago (2013-07-11 17:15:19 UTC) #5
commit-bot: I haz the power
7 years, 5 months ago (2013-07-11 17:45:53 UTC) #6
Message was sent while issue was closed.
Change committed as 154026

Powered by Google App Engine
This is Rietveld 408576698