Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 18332014: Move Copy* into the base namespace. (Closed)

Created:
7 years, 5 months ago by brettw
Modified:
7 years, 5 months ago
Reviewers:
jam
CC:
chromium-reviews, asanka, nkostylev+watch_chromium.org, tzik+watch_chromium.org, rpetterson, browser-components-watch_chromium.org, chrome-speed-team+watch_google.com, rginda+watch_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, gavinp+disk_chromium.org, benjhayden+dwatch_chromium.org, grt+watch_chromium.org, jam, joi+watch-content_chromium.org, marja+watch_chromium.org, darin-cc_chromium.org, groby+spellwatch_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, amit, rouslan+spellwatch_chromium.org, oshima+watch_chromium.org, tfarina, robertshield, davemoore+watch_chromium.org
Visibility:
Public.

Description

Move Copy* into the base namespace. This also creates a new base::internal namespace in file_util and I moved some of the internal functions in file_util to there. BUG= TBR=jam Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210600

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+402 lines, -379 lines) Patch
M base/file_util.h View 1 2 5 chunks +36 lines, -29 lines 0 comments Download
M base/file_util.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M base/file_util_mac.mm View 2 chunks +12 lines, -7 lines 0 comments Download
M base/file_util_posix.cc View 6 chunks +100 lines, -91 lines 0 comments Download
M base/file_util_unittest.cc View 1 2 3 4 11 chunks +14 lines, -13 lines 0 comments Download
M base/file_util_win.cc View 1 2 3 4 5 chunks +117 lines, -111 lines 0 comments Download
M base/prefs/json_pref_store_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_storage.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_cache.cc View 1 2 3 4 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/copy_operation.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/file_manager_browsertest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/component_patcher_operation.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/test/component_patcher_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/component_updater/test/component_patcher_unittest_win.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/component_updater/widevine_cdm_component_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/developer_private/developer_private_api.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/file_system/file_system_apitest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/i18n/i18n_apitest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/record/record_api_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/convert_user_script.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 1 2 3 4 7 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/extensions/extension_startup_browsertest.cc View 1 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/extensions/pack_extension_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/platform_app_browsertest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/sandboxed_unpacker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/sandboxed_unpacker_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/first_run/first_run.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/history_backend_unittest.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/history/history_database_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/importer/firefox_importer_browsertest.cc View 1 2 3 4 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/page_cycler/page_cycler_browsertest.cc View 1 2 3 4 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/performance_monitor/performance_monitor_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/prefs/chrome_pref_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/pref_service_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/printing_layout_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_shortcut_manager_unittest_win.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/profiles/profile_shortcut_manager_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sessions/session_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/spellchecker/spellcheck_custom_dictionary.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/metro_pin_tab_helper_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/prefs/prefs_tab_helper_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/value_store/value_store_frontend_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/web_applications/web_app_mac.mm View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/unpacker_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/setup/install.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/setup/uninstall.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/test/alternate_version_generator.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/util/copy_tree_work_item.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/util/copy_tree_work_item_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/installer/util/delete_tree_work_item.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/util/delete_tree_work_item_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/move_tree_work_item_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/automation/proxy_launcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/mini_installer_test/run_all_unittests.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/perf/generate_profile.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/perf/memory_test.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/perf/perf_ui_test_suite.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M chrome_frame/test/dll_redirector_loading_test.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome_frame/test/test_with_web_server.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cloud_print/common/win/install_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/virtual_driver/win/install/setup.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/download/base_file_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/save_file_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_browsertest.cc View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M net/disk_cache/disk_cache_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/traceline/svgui/startup-release.json View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/native_file_util.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
https://codereview.chromium.org/18332014/diff/1/chrome/browser/chromeos/drive/file_cache.cc File chrome/browser/chromeos/drive/file_cache.cc (right): https://codereview.chromium.org/18332014/diff/1/chrome/browser/chromeos/drive/file_cache.cc#newcode95 chrome/browser/chromeos/drive/file_cache.cc:95: bool CopyFileWrapper(const base::FilePath& source_path, Note: non-search-and-replace change here.
7 years, 5 months ago (2013-07-01 21:52:56 UTC) #1
brettw
7 years, 5 months ago (2013-07-09 17:42:35 UTC) #2
Message was sent while issue was closed. 
Committed patchset #5 manually as r210600 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698