Issue 18332004: No need to pass profiles to ProfilerEventsProcessor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18332004: No need to pass profiles to ProfilerEventsProcessor. (Closed)

Created:
7 years, 5 months ago by Benedikt Meurer

Modified:
7 years, 5 months ago

Reviewers:
danno, Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

No need to pass profiles to ProfilerEventsProcessor. Following up on https://codereview.chromium.org/18353002, there's no need to pass the profiles to ProfilerEventsProcessor's constructor. BUG= R=danno@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15413

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -9 lines)			Patch
M	src/cpu-profiler.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/cpu-profiler.cc	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	test/cctest/test-cpu-profiler.cc	View	4 chunks	+4 lines, -4 lines	0 comments	Download

Total messages: 3 (0 generated)

Benedikt Meurer

7 years, 5 months ago (2013-07-01 12:24:33 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r15413 (presubmit successful).