Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1895)

Unified Diff: content/public/plugin/BUILD.gn

Issue 1833193002: Content "gn check" work. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/gpu/BUILD.gn ('k') | content/public/renderer/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/plugin/BUILD.gn
diff --git a/content/public/plugin/BUILD.gn b/content/public/plugin/BUILD.gn
index e4c4d3681933cc26923da160a63f76c471202bf9..1693b4e4f5785b13060980611596a605ea31cbbd 100644
--- a/content/public/plugin/BUILD.gn
+++ b/content/public/plugin/BUILD.gn
@@ -16,6 +16,7 @@ group("plugin") {
}
source_set("plugin_sources") {
+ # External code should depend on via ":plugin" above.
visibility = [ "//content/*" ]
sources = [
@@ -24,7 +25,13 @@ source_set("plugin_sources") {
deps = [
"//base",
- "//content/plugin",
+ "//content/plugin", # Must not be a public dep.
"//content/public/common:common_sources",
]
+
+ allow_circular_includes_from = [
+ # This target is a pair with content/plugin. They always go together and
+ # include headers from each other.
+ "//content/plugin",
+ ]
}
« no previous file with comments | « content/public/gpu/BUILD.gn ('k') | content/public/renderer/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698