Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2977)

Unified Diff: content/child/BUILD.gn

Issue 1833193002: Content "gn check" work. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/tracing/BUILD.gn ('k') | content/common/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/BUILD.gn
diff --git a/content/child/BUILD.gn b/content/child/BUILD.gn
index ee79f1810f83643d094a9e98c91b17a0a670d3fa..910ba0e63bfc518c9f179d5605122c50e39fc9fd 100644
--- a/content/child/BUILD.gn
+++ b/content/child/BUILD.gn
@@ -7,9 +7,18 @@ import("//build/config/ui.gni")
import("//content/child/child.gni")
source_set("child") {
- # Only the public target should depend on this. All other targets (even
- # internal content ones) should depend on the public one.
- visibility = [ "//content/public/child:child_sources" ]
+ # Targets external to content should always link to the public API.
+ # Internal targets can link to this but only if they're child processes
+ # (i.e. not content/browser or content/common) and only if they're inside the
+ # content component (i.e. not content/test or content/shell).
+ visibility = [
+ "//content/gpu/*",
+ "//content/plugin/*",
+ "//content/ppapi_plugin/*",
+ "//content/public/child:child_sources",
+ "//content/renderer/*",
+ "//content/utility/*",
+ ]
sources = rebase_path(content_child_gypi_values.private_child_sources,
".",
@@ -33,7 +42,7 @@ source_set("child") {
"//components/webcrypto",
"//content/app/resources",
"//content/app/strings",
- "//content/common:mojo_bindings",
+ "//content/common",
"//crypto:platform",
"//mojo/common",
"//mojo/message_pump",
« no previous file with comments | « content/browser/tracing/BUILD.gn ('k') | content/common/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698