Added non-prefixed navigator.getGamepads() with updated API

Source/modules/gamepad/NavigatorGamepad.cpp

 /*
  * Copyright (C) 2011, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are met:
  *
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 10 matching lines @@
  * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
  * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH
  * DAMAGE.
  */
 
 #include "config.h"
 #include "modules/gamepad/NavigatorGamepad.h"
 
 #include "core/frame/Navigator.h"
 #include "modules/gamepad/GamepadList.h"
+#include "modules/gamepad/WebKitGamepadList.h"
 #include "public/platform/Platform.h"
 #include "wtf/PassOwnPtr.h"
 
 namespace WebCore {
 
-static void sampleGamepads(GamepadList* into)
+template<typename T>
+static void sampleGamepad(unsigned index, T& gamepad, const blink::WebGamepad& webGamepad)
+{
+    gamepad.setId(webGamepad.id);
+    gamepad.setIndex(index);
+    gamepad.setConnected(webGamepad.connected);
+    gamepad.setTimestamp(webGamepad.timestamp);
+    gamepad.setMapping(webGamepad.mapping);
+    gamepad.setAxes(webGamepad.axesLength, webGamepad.axes);
+    gamepad.setButtons(webGamepad.buttonsLength, webGamepad.buttons);
+}
+
+template<typename GamepadType, typename ListType>
+static void sampleGamepads(ListType* into)
 {
     blink::WebGamepads gamepads;
 
     blink::Platform::current()->sampleGamepads(gamepads);
 
     for (unsigned i = 0; i < blink::WebGamepads::itemsLengthCap; ++i) {
         blink::WebGamepad& webGamepad = gamepads.items[i];
         if (i < gamepads.length && webGamepad.connected) {
-            RefPtrWillBeRawPtr<Gamepad> gamepad = into->item(i);
+            RefPtrWillBeRawPtr<GamepadType> gamepad = into->item(i);
             if (!gamepad)
-                gamepad = Gamepad::create();
-            gamepad->id(webGamepad.id);
-            gamepad->index(i);
-            gamepad->connected(webGamepad.connected);
-            gamepad->timestamp(webGamepad.timestamp);
-#if defined(ENABLE_NEW_GAMEPAD_API)
-            gamepad->mapping(webGamepad.mapping);
-#endif
-            gamepad->axes(webGamepad.axesLength, webGamepad.axes);
-            gamepad->buttons(webGamepad.buttonsLength, webGamepad.buttons);
+                gamepad = GamepadType::create();

[eseidel, 2014/03/12 22:25:26]

Unfortunate that we need to do a malloc on every sample.  Then again, I suspect
we do several.

+            sampleGamepad(i, *gamepad, webGamepad);
             into->set(i, gamepad);
         } else {
             into->set(i, nullptr);
         }
     }
 }
 
 NavigatorGamepad::NavigatorGamepad()
 {
+

[eseidel, 2014/03/12 22:25:26]

spurious.

 }
 
 NavigatorGamepad::~NavigatorGamepad()
 {
+
 }
 
 const char* NavigatorGamepad::supplementName()
 {
     return "NavigatorGamepad";
 }
 
 NavigatorGamepad& NavigatorGamepad::from(Navigator& navigator)
 {
     NavigatorGamepad* supplement = static_cast<NavigatorGamepad*>(Supplement<Navigator>::from(navigator, supplementName()));
     if (!supplement) {
         supplement = new NavigatorGamepad();
         provideTo(navigator, supplementName(), adoptPtr(supplement));
     }
     return *supplement;
 }
 
-GamepadList* NavigatorGamepad::webkitGetGamepads(Navigator& navigator)
+WebKitGamepadList* NavigatorGamepad::webkitGetGamepads(Navigator& navigator)
+{
+    return NavigatorGamepad::from(navigator).webkitGamepads();
+}
+
+GamepadList* NavigatorGamepad::getGamepads(Navigator& navigator)
 {
     return NavigatorGamepad::from(navigator).gamepads();
 }
 
+WebKitGamepadList* NavigatorGamepad::webkitGamepads()
+{
+    if (!m_webkitGamepads)
+        m_webkitGamepads = WebKitGamepadList::create();
+    sampleGamepads<WebKitGamepad>(m_webkitGamepads.get());

[eseidel, 2014/03/12 22:25:26]

Woh, crazy.  So they can sample multiple times per frame or however often they
want I guess.

+    return m_webkitGamepads.get();
+}
+
 GamepadList* NavigatorGamepad::gamepads()
 {
     if (!m_gamepads)
         m_gamepads = GamepadList::create();
-    sampleGamepads(m_gamepads.get());
+    sampleGamepads<Gamepad>(m_gamepads.get());
     return m_gamepads.get();
 }
 
 } // namespace WebCore