Make EXC_BAD_ACCESS / EXC_I386_GPFLT print nicely in the processor

src/processor/minidump_processor.cc

 // Copyright (c) 2006, Google Inc.
 // All rights reserved.
 //
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 // notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
@@ skipping 727 matching lines @@
                     reason.append("EXC_PPC_BADSPACE");
                     break;
                   case MD_EXCEPTION_CODE_MAC_PPC_UNALIGNED:
                     reason.append("EXC_PPC_UNALIGNED");
                     break;
                   default:
                     reason.append(flags_string);
                     BPLOG(INFO) << "Unknown exception reason " << reason;
                     break;
                 }
+              } else if (raw_system_info->processor_architecture ==
+                         MD_CPU_ARCHITECTURE_X86 ||
+                         raw_system_info->processor_architecture ==
+                         MD_CPU_ARCHITECTURE_AMD64) {
+                switch (exception_flags) {
+                  case MD_EXCEPTION_CODE_MAC_X86_GENERAL_PROTECTION_FAULT:
+                    reason.append("EXC_I386_GPFLT");
+                    break;
+                  default:
+                    reason.append(flags_string);
+                    BPLOG(INFO) << "Unknown exception reason " << reason;
+                    break;
+                }
               } else {
                 reason.append(flags_string);
                 BPLOG(INFO) << "Unknown exception reason " << reason;
               }
               break;
           }
           break;
         case MD_EXCEPTION_MAC_BAD_INSTRUCTION:
           reason = "EXC_BAD_INSTRUCTION / ";
           switch (raw_system_info->processor_architecture) {
@@ skipping 30 matching lines @@
                 case MD_EXCEPTION_CODE_MAC_PPC_PERFORMANCE_MONITOR:
                   reason.append("EXC_PPC_PERFMON");
                   break;
                 default:
                   reason.append(flags_string);
                   BPLOG(INFO) << "Unknown exception reason " << reason;
                   break;
               }
               break;
             }
+            case MD_CPU_ARCHITECTURE_AMD64:
             case MD_CPU_ARCHITECTURE_X86: {
               switch (exception_flags) {
                 case MD_EXCEPTION_CODE_MAC_X86_INVALID_OPERATION:
                   reason.append("EXC_I386_INVOP");
                   break;
                 case MD_EXCEPTION_CODE_MAC_X86_INVALID_TASK_STATE_SEGMENT:
                   reason.append("EXC_INVTSSFLT");

[Mark Mentovai, 2016/03/29 15:21:57]

All of the rest of these are EXC_I386_* too.

                   break;
                 case MD_EXCEPTION_CODE_MAC_X86_SEGMENT_NOT_PRESENT:
                   reason.append("EXC_SEGNPFLT");
                   break;
                 case MD_EXCEPTION_CODE_MAC_X86_STACK_FAULT:
                   reason.append("EXC_STKFLT");
                   break;
                 case MD_EXCEPTION_CODE_MAC_X86_GENERAL_PROTECTION_FAULT:
-                  reason.append("EXC_GPFLT");
+                  reason.append("EXC_I386_GPFLT");
                   break;
                 case MD_EXCEPTION_CODE_MAC_X86_ALIGNMENT_FAULT:
                   reason.append("EXC_ALIGNFLT");
                   break;
                 default:
                   reason.append(flags_string);
                   BPLOG(INFO) << "Unknown exception reason " << reason;
                   break;
               }
               break;
@@ skipping 35 matching lines @@
                   break;
                 case MD_EXCEPTION_CODE_MAC_PPC_ALTIVEC_ASSIST:
                   reason.append("EXC_PPC_ALTIVECASSIST");
                 default:
                   reason.append(flags_string);
                   BPLOG(INFO) << "Unknown exception reason " << reason;
                   break;
               }
               break;
             }
+            case MD_CPU_ARCHITECTURE_AMD64:
             case MD_CPU_ARCHITECTURE_X86: {
               switch (exception_flags) {
                 case MD_EXCEPTION_CODE_MAC_X86_DIV:
                   reason.append("EXC_I386_DIV");
                   break;
                 case MD_EXCEPTION_CODE_MAC_X86_INTO:
                   reason.append("EXC_I386_INTO");
                   break;
                 case MD_EXCEPTION_CODE_MAC_X86_NOEXT:
                   reason.append("EXC_I386_NOEXT");
@@ skipping 80 matching lines @@
                 case MD_EXCEPTION_CODE_MAC_PPC_BREAKPOINT:
                   reason.append("EXC_PPC_BREAKPOINT");
                   break;
                 default:
                   reason.append(flags_string);
                   BPLOG(INFO) << "Unknown exception reason " << reason;
                   break;
               }
               break;
             }
+            case MD_CPU_ARCHITECTURE_AMD64:
             case MD_CPU_ARCHITECTURE_X86: {
               switch (exception_flags) {
                 case MD_EXCEPTION_CODE_MAC_X86_SGL:
                   reason.append("EXC_I386_SGL");
                   break;
                 case MD_EXCEPTION_CODE_MAC_X86_BPT:
                   reason.append("EXC_I386_BPT");
                   break;
                 default:
                   reason.append(flags_string);
@@ skipping 557 matching lines @@
     char assertion_line[32];
     snprintf(assertion_line, sizeof(assertion_line), "%u", raw_assertion->line);
     assertion_string.append(" at line ");
     assertion_string.append(assertion_line);
   }
 
   return assertion_string;
 }
 
 }  // namespace google_breakpad