Make EXC_BAD_ACCESS / EXC_I386_GPFLT print nicely in the processor

src/processor/minidump_processor.cc

 // Copyright (c) 2006, Google Inc.
 // All rights reserved.
 //
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 // notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
@@ skipping 727 matching lines @@
                     reason.append("EXC_PPC_BADSPACE");
                     break;
                   case MD_EXCEPTION_CODE_MAC_PPC_UNALIGNED:
                     reason.append("EXC_PPC_UNALIGNED");
                     break;
                   default:
                     reason.append(flags_string);
                     BPLOG(INFO) << "Unknown exception reason " << reason;
                     break;
                 }
+              } else if (raw_system_info->processor_architecture ==
+                         MD_CPU_ARCHITECTURE_X86 ||
+                         raw_system_info->processor_architecture ==
+                         MD_CPU_ARCHITECTURE_AMD64) {
+                switch (exception_flags) {
+                  case MD_EXCEPTION_CODE_MAC_X86_GENERAL_PROTECTION_FAULT:
+                    reason.append("EXC_GPFLT");

[Mark Mentovai, 2016/03/25 14:52:24]

EXC_I386_GPFLT. Fix the change description too.

[Ted Mielczarek, 2016/03/25 15:46:44]

I copied this from:
https://chromium.googlesource.com/breakpad/breakpad/+/master/src/processor/mi...

Do you want that changed or should we leave it?

+                    break;
+                  default:
+                    reason.append(flags_string);
+                    BPLOG(INFO) << "Unknown exception reason " << reason;
+                    break;
+                }
               } else {
                 reason.append(flags_string);
                 BPLOG(INFO) << "Unknown exception reason " << reason;
               }
               break;
           }
           break;
         case MD_EXCEPTION_MAC_BAD_INSTRUCTION:
           reason = "EXC_BAD_INSTRUCTION / ";
           switch (raw_system_info->processor_architecture) {
@@ skipping 778 matching lines @@
     char assertion_line[32];
     snprintf(assertion_line, sizeof(assertion_line), "%u", raw_assertion->line);
     assertion_string.append(" at line ");
     assertion_string.append(assertion_line);
   }
 
   return assertion_string;
 }
 
 }  // namespace google_breakpad