Issue 18331004: Refactoring and cleanup of control instructions

Issue 18331004: Refactoring and cleanup of control instructions (Closed)

Created:
7 years, 5 months ago by danno

Modified:
7 years, 5 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Refactoring and cleanup of control instructions R=mstarzinger@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=15513

Patch Set 3 : Review feedback #

Patch Set 4 : Merge with ToT #

Patch Set 5 : Rebase to ToT #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+132 lines, -155 lines)			Patch
M	src/arm/lithium-arm.h	View	1 2	3 chunks	+6 lines, -5 lines	0 comments	Download
M	src/arm/lithium-arm.cc	View	1 2	3 chunks	+5 lines, -5 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	src/code-stubs-hydrogen.cc	View	1 2 3	6 chunks	+14 lines, -9 lines	0 comments	Download
M	src/hydrogen.h	View	1 2 3	5 chunks	+26 lines, -29 lines	0 comments	Download
M	src/hydrogen.cc	View	1 2 3	14 chunks	+29 lines, -50 lines	0 comments	Download
M	src/hydrogen-instructions.h	View	1 2 3	5 chunks	+10 lines, -22 lines	0 comments	Download
M	src/hydrogen-instructions.cc	View	1 2 3	4 chunks	+6 lines, -6 lines	0 comments	Download
M	src/hydrogen-osr.cc	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/hydrogen-range-analysis.h	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/hydrogen-range-analysis.cc	View	1 2 3	2 chunks	+4 lines, -3 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	src/ia32/lithium-ia32.h	View	1 2	3 chunks	+6 lines, -5 lines	0 comments	Download
M	src/ia32/lithium-ia32.cc	View	1 2	4 chunks	+5 lines, -5 lines	0 comments	Download
M	src/objects.cc	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/lithium-x64.h	View	1 2	3 chunks	+6 lines, -5 lines	0 comments	Download
M	src/x64/lithium-x64.cc	View	1 2 3	4 chunks	+5 lines, -5 lines	0 comments	Download
M	test/mjsunit/regress/regress-2537.js	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM with nits. https://codereview.chromium.org/18331004/diff/2001/src/code-stubs-hydrogen.cc File src/code-stubs-hydrogen.cc (right): https://codereview.chromium.org/18331004/diff/2001/src/code-stubs-hydrogen.cc#newcode810 src/code-stubs-hydrogen.cc:810: Handle<Map> placeholder_map(Handle<Map>(isolate()->heap()->meta_map())); nit: Just use "Handle<Map> ...

7 years, 5 months ago (2013-07-01 12:30:39 UTC) #2

danno

Feedback addressed, landing. https://codereview.chromium.org/18331004/diff/2001/src/code-stubs-hydrogen.cc File src/code-stubs-hydrogen.cc (right): https://codereview.chromium.org/18331004/diff/2001/src/code-stubs-hydrogen.cc#newcode810 src/code-stubs-hydrogen.cc:810: Handle<Map> placeholder_map(Handle<Map>(isolate()->heap()->meta_map())); On 2013/07/01 12:30:39, Michael ...

7 years, 5 months ago (2013-07-05 09:52:39 UTC) #3

danno

7 years, 5 months ago (2013-07-05 10:40:26 UTC) #4

Message was sent while issue was closed.

Committed patchset #5 manually as r15513 (presubmit successful).

Expand Messages | Collapse Messages