Disable connection migration if disabled in config sent by server.

Disable connection migration if disabled in config sent by server.

R=rch@chromium.org
BUG=576998
Committed: https://crrev.com/9c54157003a42382c1ed3a2bd56e9f40401b452a
Cr-Commit-Position: refs/heads/master@{#383763}

[Jana, 2016-03-25 07:41:35]

jri@chromium.org changed reviewers:
+ asvitkine@chromium.org

[Jana, 2016-03-25 07:41:35]

+asvitkine for histograms.

[Ryan Hamilton, 2016-03-26 15:44:47]

lgtm, but I think we can reuse an existing error code.

https://codereview.chromium.org/1833093002/diff/20001/net/quic/quic_protocol.h
File net/quic/quic_protocol.h (right):

https://codereview.chromium.org/1833093002/diff/20001/net/quic/quic_protocol....
net/quic/quic_protocol.h:671: QUIC_CONNECTION_MIGRATION_DISABLED = 88,
I wonder if it wouldn't be simpler to use QUIC_IP_ADDRESS_CHANGED?

[Jana, 2016-03-28 17:03:20]

Thanks, Ryan. Addressed nit.

https://codereview.chromium.org/1833093002/diff/20001/net/quic/quic_protocol.h
File net/quic/quic_protocol.h (right):

https://codereview.chromium.org/1833093002/diff/20001/net/quic/quic_protocol....
net/quic/quic_protocol.h:671: QUIC_CONNECTION_MIGRATION_DISABLED = 88,
On 2016/03/26 15:44:47, Ryan Hamilton wrote:
> I wonder if it wouldn't be simpler to use QUIC_IP_ADDRESS_CHANGED?

Makes sense. Done.

[Alexei Svitkine (slow), 2016-03-29 14:50:08]

lgtm

[Jana, 2016-03-29 16:41:06]

The CQ bit was checked by jri@chromium.org

[Jana, 2016-03-29 16:41:07]

The patchset sent to the CQ was uploaded after l-g-t-m from rch@chromium.org
Link to the patchset: https://codereview.chromium.org/1833093002/#ps40001
(title: "Unnecessary error code removed.")

[commit-bot: I haz the power, 2016-03-29 16:41:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1833093002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1833093002/40001

[commit-bot: I haz the power, 2016-03-29 17:51:58]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-29 17:54:00]

Description was changed from

==========
Disable connection migration if disabled in config sent by server.

R=rch@chromium.org
BUG=576998
==========

to

==========
Disable connection migration if disabled in config sent by server.

R=rch@chromium.org
BUG=576998

Committed: https://crrev.com/9c54157003a42382c1ed3a2bd56e9f40401b452a
Cr-Commit-Position: refs/heads/master@{#383763}
==========

[commit-bot: I haz the power, 2016-03-29 17:54:01]

Patchset 3 (id:??) landed as
https://crrev.com/9c54157003a42382c1ed3a2bd56e9f40401b452a
Cr-Commit-Position: refs/heads/master@{#383763}