Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 1833053002: util.printd() replaces specified date with current date. (Closed)

Created:
4 years, 9 months ago by Tom Sepez
Modified:
4 years, 9 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

util.printd() replaces specified date with current date. Added test case. Several bugs going on here: JS_LocalTime() ignoring argument and returning current time and not factoring in the time zone adjustment. Use of FXSYS_floor() silently casts result to float, losing precision required to extract minutes and seconds. Pre-existing wcsftime escapes not stripped. BUG=pdfium:413 Committed: https://pdfium.googlesource.com/pdfium/+/86a61dc374e8abe351df03a1aa6665013cc39345

Patch Set 1 #

Patch Set 2 : Kill dead code. #

Patch Set 3 : Fix spelling. #

Patch Set 4 : Tidy. #

Patch Set 5 : Fix test cases. #

Patch Set 6 : h is wrong, not H. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+216 lines, -168 lines) Patch
M DEPS View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/javascript/JS_Value.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M fpdfsdk/javascript/util.h View 1 2 3 2 chunks +0 lines, -7 lines 0 comments Download
M fpdfsdk/javascript/util.cpp View 1 2 3 9 chunks +66 lines, -155 lines 0 comments Download
A testing/resources/javascript/util_printd.in View 1 2 3 4 5 1 chunk +104 lines, -0 lines 0 comments Download
A testing/resources/javascript/util_printd_expected.txt View 1 2 3 4 5 1 chunk +40 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Tom Sepez
Dan, for review.
4 years, 9 months ago (2016-03-24 23:20:53 UTC) #4
dsinclair
Alert: M: 59 Alert: ss: 58 Alert: s: 58 -Alert: tt: pm +Alert: tt: P ...
4 years, 9 months ago (2016-03-25 01:01:19 UTC) #5
dsinclair
lgtm once the test is figured out.
4 years, 9 months ago (2016-03-25 01:48:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1833053002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1833053002/100001
4 years, 9 months ago (2016-03-25 17:00:00 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-25 17:00:14 UTC) #11
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://pdfium.googlesource.com/pdfium/+/86a61dc374e8abe351df03a1aa6665013cc3...

Powered by Google App Engine
This is Rietveld 408576698