Fix all strong mode errors and warnings.

test/declaration_test.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library declaration_test;
 
+import 'package:csslib/src/messages.dart';
+import 'package:csslib/visitor.dart';
 import 'package:test/test.dart';
 
 import 'testing.dart';
 
 void testSimpleTerms() {
-  var errors = [];
+  var errors = <Message>[];
   final String input = r'''
 @ import url("test.css");
 .foo {
   background-color: #191919;
   width: 10PX;
   height: 22mM !important;
   border-width: 20cm;
   margin-width: 33%;
   border-height: 30EM;
   width: .6in;
@@ skipping 34 matching lines @@
   expect(stylesheet != null, true);
   expect(errors.isEmpty, true, reason: errors.toString());
   expect(prettyPrint(stylesheet), generated2);
 }
 
 /**
  * Declarations with comments, references with single-quotes, double-quotes,
  * no quotes.  Hex values with # and letters, and functions (rgba, url, etc.)
  */
 void testDeclarations() {
-  var errors = [];
+  var errors = <Message>[];
   final String input = r'''
 .more {
   color: white;
   color: black;
   color: cyan;
   color: red;
   color: #aabbcc;  /* test -- 3 */
   color: blue;
   background-image: url(http://test.jpeg);
   background-image: url("http://double_quote.html");
@@ skipping 17 matching lines @@
 }''';
 
   var stylesheet = parseCss(input, errors: errors);
 
   expect(stylesheet != null, true);
   expect(errors.isEmpty, true, reason: errors.toString());
   expect(prettyPrint(stylesheet), generated);
 }
 
 void testIdentifiers() {
-  var errors = [];
+  var errors = <Message>[];
   final String input = r'''
 #da {
   height: 100px;
 }
 #foo {
   width: 10px;
   color: #ff00cc;
 }
 ''';
   final String generated = r'''
 #da {
   height: 100px;
 }
 #foo {
   width: 10px;
   color: #f0c;
 }''';
 
   var stylesheet = parseCss(input, errors: errors);
 
   expect(errors.isEmpty, true, reason: errors.toString());
   expect(stylesheet != null, true);
   expect(prettyPrint(stylesheet), generated);
 }
 
 void testComposites() {
-  var errors = [];
+  var errors = <Message>[];
   final String input = r'''
 .xyzzy {
   border: 10px 80px 90px 100px;
   width: 99%;
 }
 @-webkit-keyframes pulsate {
   0% {
     -webkit-transform: translate3d(0, 0, 0) scale(1.0);
   }
 }''';
   final String generated = r'''
 .xyzzy {
   border: 10px 80px 90px 100px;
   width: 99%;
 }
 @-webkit-keyframes pulsate {
   0% {
   -webkit-transform: translate3d(0, 0, 0) scale(1.0);
   }
 }''';
 
   var stylesheet = parseCss(input, errors: errors);
   expect(stylesheet != null, true);
   expect(errors.isEmpty, true, reason: errors.toString());
   expect(prettyPrint(stylesheet), generated);
 }
 
 void testUnits() {
-  var errors = [];
+  var errors = <Message>[];
   final String input = r'''
 #id-1 {
   transition: color 0.4s;
   animation-duration: 500ms;
   top: 1em;
   left: 200ex;
   right: 300px;
   bottom: 400cm;
   border-width: 2.5mm;
   margin-top: .5in;
@@ skipping 63 matching lines @@
 }''';
 
   var stylesheet = parseCss(input, errors: errors, opts: simpleOptions);
 
   expect(stylesheet != null, true);
   expect(errors.isEmpty, true, reason: errors.toString());
   expect(prettyPrint(stylesheet), generated);
 }
 
 void testUnicode() {
-  var errors = [];
+  var errors = <Message>[];
   final String input = r'''
 .toggle:after {
   content: '✔';
   line-height: 43px;
   font-size: 20px;
   color: #d9d9d9;
   text-shadow: 0 -1px 0 #bfbfbf;
 }
 ''';
 
   final String generated = r'''
 .toggle:after {
   content: '✔';
   line-height: 43px;
   font-size: 20px;
   color: #d9d9d9;
   text-shadow: 0 -1px 0 #bfbfbf;
 }''';
 
   var stylesheet = parseCss(input, errors: errors);
 
   expect(stylesheet != null, true);
   expect(errors.isEmpty, true, reason: errors.toString());
   expect(prettyPrint(stylesheet), generated);
 }
 
 void testNewerCss() {
-  var errors = [];
+  var errors = <Message>[];
   final String input = r'''
 @media screen,print {
   .foobar_screen {
     width: 10px;
   }
 }
 @page {
   height: 22px;
   size: 3in 3in;
 }
@@ skipping 26 matching lines @@
 @charset "ASCII";''';
 
   var stylesheet = parseCss(input, errors: errors);
 
   expect(stylesheet != null, true);
   expect(errors.isEmpty, true, reason: errors.toString());
   expect(prettyPrint(stylesheet), generated);
 }
 
 void testMediaQueries() {
-  var errors = [];
+  var errors = <Message>[];
   String input = '''
 @media screen and (-webkit-min-device-pixel-ratio:0) {
   .todo-item .toggle {
     background: none;
   }
   #todo-item .toggle {
     height: 40px;
   }
 }''';
   String generated = '''
@@ skipping 97 matching lines @@
       '@import "test.css" ONLY screen, NOT print (min-device-width:4000px);';
 
   stylesheet = parseCss(input, errors: errors..clear(), opts: simpleOptions);
 
   expect(stylesheet != null, true);
   expect(errors.isEmpty, true, reason: errors.toString());
   expect(prettyPrint(stylesheet), generated);
 }
 
 void testFontFace() {
-  var errors = [];
+  var errors = <Message>[];
 
   final String input = '''
 @font-face {
   font-family: BBCBengali;
   src: url(fonts/BBCBengali.ttf) format("opentype");
   unicode-range: U+0A-FF, U+980-9FF, U+????, U+3???;
 }''';
   final String generated = '''@font-face  {
   font-family: BBCBengali;
   src: url("fonts/BBCBengali.ttf") format("opentype");
@@ skipping 71 matching lines @@
   unicode-range: U+000-49F, U+2000-27FF, U+2900-2BFF, U+1D400-1D7FF;
 }''';
   stylesheet = parseCss(input4, errors: errors..clear(), opts: simpleOptions);
 
   expect(stylesheet != null, true);
   expect(errors.isEmpty, true, reason: errors.toString());
   expect(prettyPrint(stylesheet), generated4);
 }
 
 void testCssFile() {
-  var errors = [];
+  var errors = <Message>[];
   final String input = r'''
 @import 'simple.css'
 @import "test.css" print
 @import url(test.css) screen, print
 @import url(http://google.com/maps/maps.css);
 
 div[href^='test'] {
   height: 10px;
 }
 
@@ skipping 43 matching lines @@
       '  background: url("http://www.foo.com/bar.png");\n'
       '}';
   var stylesheet = parseCss(input, errors: errors);
 
   expect(stylesheet != null, true);
   expect(errors.isEmpty, true, reason: errors.toString());
   expect(prettyPrint(stylesheet), generated);
 }
 
 void testCompactEmitter() {
-  var errors = [];
+  var errors = <Message>[];
 
   // Check !import compactly emitted.
   final String input = r'''
 div {
   color: green !important;
 }
 ''';
   final String generated = "div { color: green!important; }";
 
   var stylesheet = parseCss(input, errors: errors);
 
   expect(stylesheet != null, true);
   expect(errors.isEmpty, true, reason: errors.toString());
   expect(compactOuptut(stylesheet), generated);
 
   // Check namespace directive compactly emitted.
   final String input2 = "@namespace a url(http://www.example.org/a);";
   final String generated2 = "@namespace a url(http://www.example.org/a);";
 
   var stylesheet2 = parseCss(input2, errors: errors..clear());
 
   expect(stylesheet2 != null, true);
   expect(errors.isEmpty, true, reason: errors.toString());
   expect(compactOuptut(stylesheet2), generated2);
 }
 
 void testNotSelectors() {
-  var errors = [];
+  var errors = <Message>[];
 
   final String input = r'''
 .details:not(.open-details) x-element,
 .details:not(.open-details) .summary {
   overflow: hidden;
 }
 
 .details:not(.open-details) x-icon {
   margin-left: 99px;
 }
@@ skipping 69 matching lines @@
 }''';
 
   var stylesheet = parseCss(input, errors: errors, opts: simpleOptions);
 
   expect(stylesheet != null, true);
   expect(errors.isEmpty, true, reason: errors.toString());
   expect(prettyPrint(stylesheet), generated);
 }
 
 void testIE() {
-  var errors = [];
+  var errors = <Message>[];
   final String input = ".test {\n"
       "  filter: progid:DXImageTransform.Microsoft.gradient"
       "(GradientType=0,StartColorStr='#9d8b83', EndColorStr='#847670');\n"
       "}";
   final String generated = ".test {\n"
       "  filter: progid:DXImageTransform.Microsoft.gradient"
       "(GradientType=0,StartColorStr='#9d8b83', EndColorStr='#847670');\n"
       "}";
 
   var stylesheet = parseCss(input, errors: errors, opts: simpleOptions);
@@ skipping 55 matching lines @@
  *  Test IE specific declaration syntax:
  *    IE6 property name prefixed with _ (normal CSS property name can start
  *    with an underscore).
  *
  *    IE7 or below property add asterisk before the CSS property.
  *
  *    IE8 or below add \9 at end of declaration expression e.g.,
  *        background: red\9;
  */
 void testIEDeclaration() {
-  var errors = [];
+  var errors = <Message>[];
 
   final input = '''
 .testIE-6 {
   _zoom : 5;
 }
 .clearfix {
   *zoom: 1;
 }
 audio, video {
   display: inline-block;
@@ skipping 145 matching lines @@
   }
 }''';
 
   var stylesheet = parseCss(input, errors: errors, opts: simpleOptions);
   expect(stylesheet != null, true);
   expect(errors.isEmpty, true, reason: errors.toString());
   expect(prettyPrint(stylesheet), generated);
 }
 
 void testHangs() {
-  var errors = [];
+  var errors = <Message>[];
 
   // Bad hexvalue had caused a hang in processTerm.
   final input = r'''#a { color: #ebebeburl(0/IE8+9+); }''';
   var stylesheet = parseCss(input, errors: errors, opts: options);
 
   expect(stylesheet != null, true);
   expect(errors.length, 3, reason: errors.toString());
 
   var errorMessage = errors[0];
   expect(errorMessage.message, contains('Bad hex number'));
@@ skipping 36 matching lines @@
   expect(errorMessage.message, contains('unexpected end of file'));
   expect(errorMessage.span, isNotNull);
   expect(errorMessage.span.start.line, 7);
   expect(errorMessage.span.start.column, 0);
   expect(errorMessage.span.text.trim(), '');
 }
 
 void testExpressionSpans() {
   final input = r'''.foo { width: 50px; }''';
   var stylesheet = parseCss(input);
-  var decl = stylesheet.topLevels.single.declarationGroup.declarations.single;
+  var decl = (stylesheet.topLevels.single as RuleSet)
+      .declarationGroup
+      .declarations
+      .single;
   // This passes
   expect(decl.span.text, 'width: 50px');
   // This currently fails
-  expect(decl.expression.span.text, '50px');
+  expect((decl as Declaration).expression.span.text, '50px');
 }
 
 void simpleCalc() {
   final input = r'''.foo { height: calc(100% - 55px); }''';
   var stylesheet = parseCss(input);
-  var decl = stylesheet.topLevels.single.declarationGroup.declarations.single;
+  var decl = (stylesheet.topLevels.single as RuleSet)
+      .declarationGroup
+      .declarations
+      .single;
   expect(decl.span.text, 'height: calc(100% - 55px)');
 }
 
 void complexCalc() {
   final input = r'''.foo { left: calc((100%/3 - 2) * 1em - 2 * 1px); }''';
   var stylesheet = parseCss(input);
-  var decl = stylesheet.topLevels.single.declarationGroup.declarations.single;
+  var decl = (stylesheet.topLevels.single as RuleSet)
+      .declarationGroup
+      .declarations
+      .single;
   expect(decl.span.text, 'left: calc((100%/3 - 2) * 1em - 2 * 1px)');
 }
 
 void twoCalcs() {
   final input = r'''.foo { margin: calc(1rem - 2px) calc(1rem - 1px); }''';
   var stylesheet = parseCss(input);
-  var decl = stylesheet.topLevels.single.declarationGroup.declarations.single;
+  var decl = (stylesheet.topLevels.single as RuleSet)
+      .declarationGroup
+      .declarations
+      .single;
   expect(decl.span.text, 'margin: calc(1rem - 2px) calc(1rem - 1px)');
 }
 
 void selectorWithCalcs() {
-  var errors = [];
+  var errors = <Message>[];
   final String input = r'''
 .foo {
   width: calc(1em + 5 * 2em);
   height: calc(1px + 2%) !important;
   border: 5px calc(1pt + 2cm) 6px calc(1em + 1in + 2px) red;
   border: calc(5px + 1em) 0px 1px calc(10 + 20 + 1px);
   margin: 25px calc(50px + (100% / (3 - 1em) - 20%)) calc(10px + 10 * 20) calc(100% - 10px);
 }''';
   final String generated = r'''
 .foo {
@@ skipping 21 matching lines @@
   test('Media Queries', testMediaQueries);
   test('Font-Face', testFontFace);
   test('CSS file', testCssFile);
   test('Compact Emitter', testCompactEmitter);
   test('Selector Negation', testNotSelectors);
   test('IE stuff', testIE);
   test('IE declaration syntax', testIEDeclaration);
   test('Hanging bugs', testHangs);
   test('Expression spans', testExpressionSpans,
       skip: 'expression spans are broken'
-            ' (https://github.com/dart-lang/csslib/issues/15)');
+          ' (https://github.com/dart-lang/csslib/issues/15)');
   group('calc function', () {
     test('simple calc', simpleCalc);
     test('single complex', complexCalc);
     test('two calc terms for same declaration', twoCalcs);
     test('selector with many calc declarations', selectorWithCalcs);
   });
 }
-