Fix all strong mode errors and warnings.

Fix all strong mode errors and warnings.

This is almost all:

- Adding type annotations to empty lists that are later filled. Many
  of these could be simplified by using .map(...).toList() to create
  the list instead, but I wanted to minimize my changes.
- Adding type arguments to some List annotations.

I did find one thing that I believe was a bug where a list was being
inadvertently flattened. Strong mode caught that.

R=terry@google.com

Committed: https://github.com/dart-lang/csslib/commit/c75e20cea8e7bbe44937262de51d636ac5d4c7a1

[Bob Nystrom, 2016-03-25 03:10:41]

rnystrom@google.com changed reviewers:
+ terry@google.com

[Bob Nystrom, 2016-03-25 03:11:28]

https://codereview.chromium.org/1832993003/diff/1/lib/src/tree.dart
File lib/src/tree.dart (right):

https://codereview.chromium.org/1832993003/diff/1/lib/src/tree.dart#newcode748
lib/src/tree.dart:748: cloneArgs.add(arg.map((term) => term.clone()).toList());
I believe the previous code was wrong here.

[terry, 2016-04-14 21:16:43]

lgtm just minor questions.

https://codereview.chromium.org/1832993003/diff/1/lib/parser.dart
File lib/parser.dart (right):

https://codereview.chromium.org/1832993003/diff/1/lib/parser.dart#newcode778
lib/parser.dart:778: List<VarDefinition> params = [];
var params = <VarDefinition>[];

https://codereview.chromium.org/1832993003/diff/1/lib/src/property.dart
File lib/src/property.dart (right):

https://codereview.chromium.org/1832993003/diff/1/lib/src/property.dart#newco...
lib/src/property.dart:1235: /*=T*/ _mergeVal/*<T>*/(/*=T*/ x, /*=T*/ y) => y !=
null ? y : x;
grep/regex ?

[Bob Nystrom, 2016-04-21 00:06:59]

Thanks!

https://codereview.chromium.org/1832993003/diff/1/lib/parser.dart
File lib/parser.dart (right):

https://codereview.chromium.org/1832993003/diff/1/lib/parser.dart#newcode778
lib/parser.dart:778: List<VarDefinition> params = [];
On 2016/04/14 21:16:43, terry wrote:
> var params = <VarDefinition>[];

Done.

https://codereview.chromium.org/1832993003/diff/1/lib/src/property.dart
File lib/src/property.dart (right):

https://codereview.chromium.org/1832993003/diff/1/lib/src/property.dart#newco...
lib/src/property.dart:1235: /*=T*/ _mergeVal/*<T>*/(/*=T*/ x, /*=T*/ y) => y !=
null ? y : x;
On 2016/04/14 21:16:43, terry wrote:
> grep/regex ?

Heh, nope. This is the actual current comment-based generic method syntax. With
the real syntax, this will become:

T _mergeVal<T>(T x, T y) => y != null ? y : x;

But the VM and dart2js don't support that yet.

[Bob Nystrom, 2016-04-21 00:07:20]

Description was changed from

==========
Fix all strong mode errors and warnings.

This is almost all:

- Adding type annotations to empty lists that are later filled. Many
  of these could be simplified by using .map(...).toList() to create
  the list instead, but I wanted to minimize my changes.
- Adding type arguments to some List annotations.

I did find one thing that I believe was a bug where a list was being
inadvertently flattened. Strong mode caught that.
==========

to

==========
Fix all strong mode errors and warnings.

This is almost all:

- Adding type annotations to empty lists that are later filled. Many
  of these could be simplified by using .map(...).toList() to create
  the list instead, but I wanted to minimize my changes.
- Adding type arguments to some List annotations.

I did find one thing that I believe was a bug where a list was being
inadvertently flattened. Strong mode caught that.

R=terry@google.com

Committed:
https://github.com/dart-lang/csslib/commit/c75e20cea8e7bbe44937262de51d636ac5...
==========

[Bob Nystrom, 2016-04-21 00:07:21]

Committed patchset #2 (id:20001) manually as
c75e20cea8e7bbe44937262de51d636ac5d4c7a1 (presubmit successful).