Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 1832973002: Don't highlight branches named 'origin-foo' (Closed)

Created:
4 years, 9 months ago by jsbell
Modified:
4 years, 9 months ago
Reviewers:
iannucci1, iannucci
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't highlight branches named 'origin-foo' Logic for highlighting "origin/master" (etc) just looked for "origin" as a prefix. Add the slash since "origin-foo" is a boring old valid topic branch name. R=iannucci@chromium.org, iannucci@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=299486

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M git_map_branches.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
jsbell
iannucci@ - please take a look? Maybe the original code was intentional in some way?
4 years, 9 months ago (2016-03-24 19:00:07 UTC) #2
iannucci1
nope, original behavior was not intentional. lgtm :)
4 years, 9 months ago (2016-03-24 20:30:55 UTC) #4
iannucci
(lgtm from chromium)
4 years, 9 months ago (2016-03-24 20:31:12 UTC) #5
jsbell
4 years, 9 months ago (2016-03-24 22:23:52 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 299486.

Powered by Google App Engine
This is Rietveld 408576698