ui/views/animation/ink_drop_animation_controller_impl.cc - Issue 1832963002: MD - add ripples to DL shelf items

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/animation/ink_drop_animation_controller_impl.cc

Issue 1832963002: MD - add ripples to DL shelf items (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: bruthig feedback Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/animation/ink_drop_animation_controller_impl.cc

diff --git a/ui/views/animation/ink_drop_animation_controller_impl.cc b/ui/views/animation/ink_drop_animation_controller_impl.cc

index def6df3bb6f0b75a9938766ca38dabad570b65b3..811cd82451939d23dffd22a01acb8990b72d229d 100644

--- a/ui/views/animation/ink_drop_animation_controller_impl.cc

+++ b/ui/views/animation/ink_drop_animation_controller_impl.cc

@@ -113,7 +113,7 @@ void InkDropAnimationControllerImpl::SetHovered(bool is_hovered) {

void InkDropAnimationControllerImpl::CompleteHiddenTargetedAnimations() {

if (ink_drop_animation_->target_ink_drop_state() == InkDropState::HIDDEN ||

ShouldAnimateToHidden(ink_drop_animation_->target_ink_drop_state())) {

- ink_drop_animation_->HideImmediately();

+ CreateInkDropAnimation();

}