ui/views/controls/button/menu_button.cc - Issue 1832963002: MD - add ripples to DL shelf items

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/button/menu_button.cc

Issue 1832963002: MD - add ripples to DL shelf items (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix another TODO Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/controls/button/menu_button.cc

diff --git a/ui/views/controls/button/menu_button.cc b/ui/views/controls/button/menu_button.cc

index 41921b923dbabc7f804ee752d0ffa7a353b0eb50..4d1a1b9728157e8581a4ec725a94de28183a7715 100644

--- a/ui/views/controls/button/menu_button.cc

+++ b/ui/views/controls/button/menu_button.cc

@@ -150,7 +150,7 @@ bool MenuButton::Activate(const ui::Event* event) {

if (ink_drop_delegate() && !increment_pressed_lock_called &&

pressed_lock_count_ == 0) {

- ink_drop_delegate()->OnAction(InkDropState::QUICK_ACTION);

+ ink_drop_delegate()->OnAction(InkDropState::ACTION_TRIGGERED);

}

// We must return false here so that the RootView does not get stuck