ui/views/animation/ink_drop_animation_controller_impl.h - Issue 1832963002: MD - add ripples to DL shelf items

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/animation/ink_drop_animation_controller_impl.h

Issue 1832963002: MD - add ripples to DL shelf items (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix another TODO Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/animation/ink_drop_animation_controller_impl.h

diff --git a/ui/views/animation/ink_drop_animation_controller_impl.h b/ui/views/animation/ink_drop_animation_controller_impl.h

index 8aaf6bc5ddc96a0632bfed1ed19453403b034c32..9324b0bf8ec3d1438f12f0b782a4668e31a6ac9b 100644

--- a/ui/views/animation/ink_drop_animation_controller_impl.h

+++ b/ui/views/animation/ink_drop_animation_controller_impl.h

@@ -44,9 +44,8 @@ class VIEWS_EXPORT InkDropAnimationControllerImpl

friend class InkDropAnimationControllerFactoryTest;

friend class InkDropAnimationControllerImplTest;

- // Forcibly transition to the HIDDEN state if completing the current animation

- // sequence would eventually be HIDDEN.

- void CompleteHiddenTargetedAnimations();

+ // Destroys |ink_drop_animation_| if it's targeted to the HIDDEN state.

+ void DestroyHiddenTargetedAnimations();

// Creates a new InkDropAnimation and sets it to |ink_drop_animation_|. If

// |ink_drop_animation_| wasn't null then it will be destroyed using