Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1832943002: Add mus_demo mojo app. (Closed)

Created:
4 years, 9 months ago by kylechar
Modified:
4 years, 8 months ago
Reviewers:
rjkroege, Dirk Pranke
CC:
blundell+watchlist_chromium.org, chromium-reviews, droger+watchlist_chromium.org, kalyank, msw, rjkroege, sadrul, sdefresne+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add mus_demo mojo app. Simple mojo app that connects to mus, creates a new window and draws into the window. Draws a spinning square. Provides a simple way to test mus graphics output without the complexity of starting mash. BUG=599162 Committed: https://crrev.com/bd601e5a5d235c1c933190286c04db14b458971e Cr-Commit-Position: refs/heads/master@{#384259}

Patch Set 1 #

Patch Set 2 : Fix resize + OWNERS + cleanup. #

Patch Set 3 : Remove WindowManagerClient. #

Total comments: 13

Patch Set 4 : Fixes for comments. #

Total comments: 1

Patch Set 5 : Move from mash/BUILD.gn to BUILD.gn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+280 lines, -15 lines) Patch
M BUILD.gn View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A + components/mus/demo/BUILD.gn View 1 1 chunk +15 lines, -11 lines 0 comments Download
A components/mus/demo/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
A + components/mus/demo/OWNERS View 1 1 chunk +1 line, -1 line 0 comments Download
A + components/mus/demo/main.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
A components/mus/demo/manifest.json View 1 chunk +6 lines, -0 lines 0 comments Download
A components/mus/demo/mus_demo.h View 1 2 3 1 chunk +91 lines, -0 lines 0 comments Download
A components/mus/demo/mus_demo.cc View 1 2 3 1 chunk +159 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (9 generated)
kylechar
4 years, 8 months ago (2016-03-29 15:28:56 UTC) #2
kylechar
I've removed WindowTreeClient as it turned out to be unnecessary for the demo.
4 years, 8 months ago (2016-03-29 16:48:13 UTC) #3
rjkroege
There might already be a bug for building a "mus shell". Or if there isn't, ...
4 years, 8 months ago (2016-03-29 18:53:23 UTC) #4
kylechar
https://codereview.chromium.org/1832943002/diff/40001/components/mus/demo/mus_demo.cc File components/mus/demo/mus_demo.cc (right): https://codereview.chromium.org/1832943002/diff/40001/components/mus/demo/mus_demo.cc#newcode30 components/mus/demo/mus_demo.cc:30: void DrawSquare(const gfx::Rect& bounds, double angle, SkCanvas* canvas) { ...
4 years, 8 months ago (2016-03-29 20:43:40 UTC) #5
rjkroege
lgtm https://codereview.chromium.org/1832943002/diff/40001/components/mus/demo/mus_demo.h File components/mus/demo/mus_demo.h (right): https://codereview.chromium.org/1832943002/diff/40001/components/mus/demo/mus_demo.h#newcode69 components/mus/demo/mus_demo.h:69: mojo::Connector* connector_ = nullptr; On 2016/03/29 20:43:39, kylechar ...
4 years, 8 months ago (2016-03-29 20:56:54 UTC) #6
kylechar
Hey msw@, I'm adding you for LGTM on mash/BUILD.gn. Some BUILD.gn needs to reference //components/mus/demo ...
4 years, 8 months ago (2016-03-29 21:03:22 UTC) #8
msw
https://codereview.chromium.org/1832943002/diff/60001/mash/BUILD.gn File mash/BUILD.gn (right): https://codereview.chromium.org/1832943002/diff/60001/mash/BUILD.gn#newcode15 mash/BUILD.gn:15: "//components/mus/demo", Hmm, this is actually a sibling of mash, ...
4 years, 8 months ago (2016-03-29 21:24:31 UTC) #9
kylechar
If that's more idiomatic then sure, thanks msw@! Moved to gn_all target in BUILD.gn in ...
4 years, 8 months ago (2016-03-30 13:20:07 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1832943002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1832943002/80001
4 years, 8 months ago (2016-03-30 16:54:36 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-03-30 17:46:11 UTC) #16
Dirk Pranke
lgtm
4 years, 8 months ago (2016-03-31 01:52:15 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1832943002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1832943002/80001
4 years, 8 months ago (2016-03-31 13:06:46 UTC) #20
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 8 months ago (2016-03-31 13:11:47 UTC) #21
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 13:12:51 UTC) #23
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/bd601e5a5d235c1c933190286c04db14b458971e
Cr-Commit-Position: refs/heads/master@{#384259}

Powered by Google App Engine
This is Rietveld 408576698