components/password_manager/core/browser/credential_manager_pending_request_task.cc - Issue 1832933002: Update the |skip_zero_click| flag of a credential when selected in the account chooser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/credential_manager_pending_request_task.cc

Issue 1832933002: Update the |skip_zero_click| flag of a credential when selected in the account chooser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: comments Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/credential_manager_pending_request_task.h ('k') | components/password_manager/core/browser/password_manager_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/credential_manager_pending_request_task.cc

diff --git a/components/password_manager/core/browser/credential_manager_pending_request_task.cc b/components/password_manager/core/browser/credential_manager_pending_request_task.cc

index b2c99e23b08b0c3bdd5177c4a193f2504e8a546c..4145b18d67fe262bdaa40108954a6dfa0ad053e4 100644

--- a/components/password_manager/core/browser/credential_manager_pending_request_task.cc

+++ b/components/password_manager/core/browser/credential_manager_pending_request_task.cc

@@ -122,7 +122,7 @@ void CredentialManagerPendingRequestTask::OnGetPasswordStoreResults(

!delegate_->client()->PromptUserToChooseCredentials(

std::move(local_results), std::move(federated_results), origin_,

base::Bind(

- &CredentialManagerPendingRequestTaskDelegate::SendCredential,

+ &CredentialManagerPendingRequestTaskDelegate::SendPasswordForm,

base::Unretained(delegate_), id_))) {

if (can_use_autosignin) {

// The user had credentials, but either chose not to share them with the