Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(712)

Unified Diff: chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

Issue 1832933002: Update the |skip_zero_click| flag of a credential when selected in the account chooser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/passwords/manage_passwords_ui_controller.cc
diff --git a/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc b/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc
index 6eac8fc74f1e60d27c0f9949e5b3eb80bdd12ce8..ff01f0e5bec5c18bf7c378814735a86e6b811e1c 100644
--- a/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc
+++ b/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc
@@ -99,7 +99,7 @@ bool ManagePasswordsUIController::OnChooseCredentials(
ScopedVector<autofill::PasswordForm> local_credentials,
ScopedVector<autofill::PasswordForm> federated_credentials,
const GURL& origin,
- base::Callback<void(const password_manager::CredentialInfo&)> callback) {
+ const ManagePasswordsState::CredentialsCallback& callback) {
DCHECK(!local_credentials.empty() || !federated_credentials.empty());
PasswordDialogController::FormsVector locals =
CopyFormVector(local_credentials);
@@ -295,8 +295,10 @@ void ManagePasswordsUIController::ChooseCredential(
autofill::PasswordForm form,
password_manager::CredentialType credential_type) {
DCHECK(dialog_controller_);
+ DCHECK_EQ(password_manager::CredentialType::CREDENTIAL_TYPE_PASSWORD,
+ credential_type);
dialog_controller_.reset();
- passwords_data_.ChooseCredential(form, credential_type);
+ passwords_data_.ChooseCredential(&form);
passwords_data_.TransitionToState(password_manager::ui::MANAGE_STATE);
UpdateBubbleAndIconVisibility();
}

Powered by Google App Engine
This is Rietveld 408576698