Update the |skip_zero_click| flag of a credential when selected in the account chooser.

chrome/browser/password_manager/account_chooser_dialog_android.cc

Index: chrome/browser/password_manager/account_chooser_dialog_android.cc
diff --git a/chrome/browser/password_manager/account_chooser_dialog_android.cc b/chrome/browser/password_manager/account_chooser_dialog_android.cc
index 309253f363263530a592c4d11b5644365a3fe17c..f6723bf6c10421d7a34c5e30b575adf70b8f107d 100644
--- a/chrome/browser/password_manager/account_chooser_dialog_android.cc
+++ b/chrome/browser/password_manager/account_chooser_dialog_android.cc
@@ -206,17 +206,16 @@ void AccountChooserDialogAndroid::ChooseCredential(
     password_manager::CredentialType type) {
   using namespace password_manager;
   if (type == CredentialType::CREDENTIAL_TYPE_EMPTY) {
-    passwords_data_.ChooseCredential(autofill::PasswordForm(), type);
+    passwords_data_.ChooseCredential(nullptr);
     return;
   }
-  DCHECK(type == CredentialType::CREDENTIAL_TYPE_PASSWORD ||
-         type == CredentialType::CREDENTIAL_TYPE_FEDERATED);
+  DCHECK(type == CredentialType::CREDENTIAL_TYPE_PASSWORD);

[vabr (Chromium), 2016/03/29 08:45:55]

optional nit: One could also either define operator<< for CredentialType to make
DCHECK_EQ(CredentialType::CREDENTIAL_TYPE_PASSWORD, type) work, or at least use
DCHECK(...) << "type is " << static_cast<int>(type) to make the error log a bit
more helpful.

Similarly on line 298 in
chrome/browser/ui/passwords/manage_passwords_ui_controller.cc.

[vasilii, 2016/03/29 09:57:44]

Done.

   const auto& credentials_forms =
       (type == CredentialType::CREDENTIAL_TYPE_PASSWORD)
           ? local_credentials_forms()
           : federated_credentials_forms();
   if (index < credentials_forms.size()) {
-    passwords_data_.ChooseCredential(*credentials_forms[index], type);
+    passwords_data_.ChooseCredential(credentials_forms[index]);
   }
 }