Clean up calls to CreateGpuMemoryBufferImageCHROMIUM.

Clean up calls to CreateGpuMemoryBufferImageCHROMIUM.

This CL should not induce any behavior changes.

IOSurfaces expect a format of GL_BGRA, and an internal format of GL_RGBA.
Callers of CreateGpuMemoryBufferImageCHROMIUM were incorrectly passing in
GL_BGRA as |internalformat|, and the implementation of
CreateGpuMemoryBufferImageCHROMIUM was incorrectly allowing this. This CL
updates callsites to pass in GL_RGBA, and updates the implementation of
CreateGpuMemoryBufferImageCHROMIUM to not accept GL_BGRA.

BUG=595948
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/4d8dc295cccc146320088799dd9af2f90d71232d
Cr-Commit-Position: refs/heads/master@{#383243}

[erikchen, 2016-03-24 17:45:01]

Description was changed from

==========
Clean up calls to CreateGpuMemoryBufferImageCHROMIUM.

Enforce the requirement that |internalformat| is either GL_RGB or GL_RGBA.

BUG=595948
==========

to

==========
Clean up calls to CreateGpuMemoryBufferImageCHROMIUM.

Enforce the requirement that |internalformat| is either GL_RGB or GL_RGBA.

BUG=595948
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[erikchen, 2016-03-24 17:52:47]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-24 17:53:05]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1832923002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1832923002/1

[erikchen, 2016-03-24 19:04:11]

erikchen@chromium.org changed reviewers:
+ kbr@chromium.org

[erikchen, 2016-03-24 19:04:12]

kbr: Please review.

[Ken Russell (switch to Gerrit), 2016-03-24 19:07:56]

Description was changed from

==========
Clean up calls to CreateGpuMemoryBufferImageCHROMIUM.

Enforce the requirement that |internalformat| is either GL_RGB or GL_RGBA.

BUG=595948
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Clean up calls to CreateGpuMemoryBufferImageCHROMIUM.

Enforce the requirement that |internalformat| is either GL_RGB or GL_RGBA.

BUG=595948
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[Ken Russell (switch to Gerrit), 2016-03-24 19:10:20]

kbr@chromium.org changed reviewers:
+ ccameron@chromium.org

[Ken Russell (switch to Gerrit), 2016-03-24 19:10:21]

LGTM overall, but could you get a review from ccameron@ on the browser
compositor output surface change?

Basically, as long as everything still renders correctly this is fine, unless
for some reason the change to the IOSurface's internal format increases
Chromium's power consumption.

Also, I added tryserver.chromium.mac:mac_optional_gpu_tests_rel to your CQ
trybots. It's being auto-added again in
https://codereview.chromium.org/1829063003 . Could you please run it and make
sure it passes? Thanks.

[erikchen, 2016-03-24 19:21:31]

Description was changed from

==========
Clean up calls to CreateGpuMemoryBufferImageCHROMIUM.

Enforce the requirement that |internalformat| is either GL_RGB or GL_RGBA.

BUG=595948
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Clean up calls to CreateGpuMemoryBufferImageCHROMIUM.

Enforce the requirement that |internalformat| is either GL_RGB or GL_RGBA.

This CL should not induce any behavior changes. The previous callers of
CreateGpuMemoryBufferImageCHROMIUM were incorrectly passing in GL_BGRA_EXT.

BUG=595948
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[erikchen, 2016-03-24 19:24:23]

Description was changed from

==========
Clean up calls to CreateGpuMemoryBufferImageCHROMIUM.

Enforce the requirement that |internalformat| is either GL_RGB or GL_RGBA.

This CL should not induce any behavior changes. The previous callers of
CreateGpuMemoryBufferImageCHROMIUM were incorrectly passing in GL_BGRA_EXT.

BUG=595948
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Clean up calls to CreateGpuMemoryBufferImageCHROMIUM.

Enforce the requirement that |internalformat| is either GL_RGB or GL_RGBA.

This CL should not induce any behavior changes. The previous callers of
CreateGpuMemoryBufferImageCHROMIUM were incorrectly passing in GL_BGRA_EXT.
They've been updated to pass in GL_RGBA, which should keep the exact same
behavior.

BUG=595948
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[erikchen, 2016-03-24 19:25:30]

Description was changed from

==========
Clean up calls to CreateGpuMemoryBufferImageCHROMIUM.

Enforce the requirement that |internalformat| is either GL_RGB or GL_RGBA.

This CL should not induce any behavior changes. The previous callers of
CreateGpuMemoryBufferImageCHROMIUM were incorrectly passing in GL_BGRA_EXT.
They've been updated to pass in GL_RGBA, which should keep the exact same
behavior.

BUG=595948
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Clean up calls to CreateGpuMemoryBufferImageCHROMIUM.

Enforce the requirement that |internalformat| is either GL_RGB or GL_RGBA.

This CL should not induce any behavior changes. The previous callers of
CreateGpuMemoryBufferImageCHROMIUM were incorrectly passing in GL_BGRA_EXT.
They've been updated to pass in GL_RGBA, which has the same behavior in the
implementation.

BUG=595948
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[ccameron, 2016-03-24 19:29:58]

lgtm -- better to hide this detail from the command buffer client.

[erikchen, 2016-03-24 19:54:00]

Description was changed from

==========
Clean up calls to CreateGpuMemoryBufferImageCHROMIUM.

Enforce the requirement that |internalformat| is either GL_RGB or GL_RGBA.

This CL should not induce any behavior changes. The previous callers of
CreateGpuMemoryBufferImageCHROMIUM were incorrectly passing in GL_BGRA_EXT.
They've been updated to pass in GL_RGBA, which has the same behavior in the
implementation.

BUG=595948
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Clean up calls to CreateGpuMemoryBufferImageCHROMIUM.

This CL should not induce any behavior changes.

IOSurfaces expect a format of GL_BGRA, and an internal format of GL_RGBA.
Callers of CreateGpuMemoryBufferImageCHROMIUM were incorrectly passing in
GL_BGRA as |internalformat|, and the implementation of
CreateGpuMemoryBufferImageCHROMIUM was incorrectly aloowing this. This CL
updates callsites to pass in GL_RGBA, and updates the implementation of
CreateGpuMemoryBufferImageCHROMIUM to not accept GL_BGRA.

BUG=595948
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[erikchen, 2016-03-24 19:54:28]

Description was changed from

==========
Clean up calls to CreateGpuMemoryBufferImageCHROMIUM.

This CL should not induce any behavior changes.

IOSurfaces expect a format of GL_BGRA, and an internal format of GL_RGBA.
Callers of CreateGpuMemoryBufferImageCHROMIUM were incorrectly passing in
GL_BGRA as |internalformat|, and the implementation of
CreateGpuMemoryBufferImageCHROMIUM was incorrectly aloowing this. This CL
updates callsites to pass in GL_RGBA, and updates the implementation of
CreateGpuMemoryBufferImageCHROMIUM to not accept GL_BGRA.

BUG=595948
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Clean up calls to CreateGpuMemoryBufferImageCHROMIUM.

This CL should not induce any behavior changes.

IOSurfaces expect a format of GL_BGRA, and an internal format of GL_RGBA.
Callers of CreateGpuMemoryBufferImageCHROMIUM were incorrectly passing in
GL_BGRA as |internalformat|, and the implementation of
CreateGpuMemoryBufferImageCHROMIUM was incorrectly allowing this. This CL
updates callsites to pass in GL_RGBA, and updates the implementation of
CreateGpuMemoryBufferImageCHROMIUM to not accept GL_BGRA.

BUG=595948
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[erikchen, 2016-03-24 19:55:03]

On 2016/03/24 19:29:58, ccameron wrote:
> lgtm -- better to hide this detail from the command buffer client.

I updated the CL description to better reflect the problem:
"""
This CL should not induce any behavior changes.

IOSurfaces expect a format of GL_BGRA, and an internal format of GL_RGBA.
Callers of CreateGpuMemoryBufferImageCHROMIUM were incorrectly passing in
GL_BGRA as |internalformat|, and the implementation of
CreateGpuMemoryBufferImageCHROMIUM was incorrectly allowing this. This CL
updates callsites to pass in GL_RGBA, and updates the implementation of
CreateGpuMemoryBufferImageCHROMIUM to not accept GL_BGRA.
"""

[Ken Russell (switch to Gerrit), 2016-03-24 19:56:38]

On 2016/03/24 19:55:03, erikchen wrote:
> On 2016/03/24 19:29:58, ccameron wrote:
> > lgtm -- better to hide this detail from the command buffer client.
> 
> I updated the CL description to better reflect the problem:
> """
> This CL should not induce any behavior changes.
> 
> IOSurfaces expect a format of GL_BGRA, and an internal format of GL_RGBA.
> Callers of CreateGpuMemoryBufferImageCHROMIUM were incorrectly passing in
> GL_BGRA as |internalformat|, and the implementation of
> CreateGpuMemoryBufferImageCHROMIUM was incorrectly allowing this. This CL
> updates callsites to pass in GL_RGBA, and updates the implementation of
> CreateGpuMemoryBufferImageCHROMIUM to not accept GL_BGRA.
> """

Thanks for clarifying.

[commit-bot: I haz the power, 2016-03-24 21:06:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-24 21:06:12]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[erikchen, 2016-03-25 00:11:00]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-25 00:11:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1832923002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1832923002/20001

[erikchen, 2016-03-25 00:11:51]

erikchen@chromium.org changed reviewers:
+ zmo@chromium.org

[erikchen, 2016-03-25 00:11:51]

zmo: Please review gpu/command_buffer

[Zhenyao Mo, 2016-03-25 00:28:38]

zmo@chromium.org changed reviewers:
+ piman@chromium.org

[Zhenyao Mo, 2016-03-25 00:28:39]

piman: can you review the command buffer change instead?
I am not familiar with the GpuMemoryBufferImage code.

[piman, 2016-03-25 01:02:36]

lgtm

[commit-bot: I haz the power, 2016-03-25 02:26:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-25 02:26:50]

Dry run: This issue passed the CQ dry run.

[erikchen, 2016-03-25 04:31:52]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2016-03-25 04:31:52]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org,
ccameron@chromium.org
Link to the patchset: https://codereview.chromium.org/1832923002/#ps20001
(title: "Fix test failure.")

[commit-bot: I haz the power, 2016-03-25 04:32:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1832923002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1832923002/20001

[commit-bot: I haz the power, 2016-03-25 04:37:21]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-25 04:40:28]

Description was changed from

==========
Clean up calls to CreateGpuMemoryBufferImageCHROMIUM.

This CL should not induce any behavior changes.

IOSurfaces expect a format of GL_BGRA, and an internal format of GL_RGBA.
Callers of CreateGpuMemoryBufferImageCHROMIUM were incorrectly passing in
GL_BGRA as |internalformat|, and the implementation of
CreateGpuMemoryBufferImageCHROMIUM was incorrectly allowing this. This CL
updates callsites to pass in GL_RGBA, and updates the implementation of
CreateGpuMemoryBufferImageCHROMIUM to not accept GL_BGRA.

BUG=595948
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Clean up calls to CreateGpuMemoryBufferImageCHROMIUM.

This CL should not induce any behavior changes.

IOSurfaces expect a format of GL_BGRA, and an internal format of GL_RGBA.
Callers of CreateGpuMemoryBufferImageCHROMIUM were incorrectly passing in
GL_BGRA as |internalformat|, and the implementation of
CreateGpuMemoryBufferImageCHROMIUM was incorrectly allowing this. This CL
updates callsites to pass in GL_RGBA, and updates the implementation of
CreateGpuMemoryBufferImageCHROMIUM to not accept GL_BGRA.

BUG=595948
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/4d8dc295cccc146320088799dd9af2f90d71232d
Cr-Commit-Position: refs/heads/master@{#383243}
==========

[commit-bot: I haz the power, 2016-03-25 04:40:30]

Patchset 2 (id:??) landed as
https://crrev.com/4d8dc295cccc146320088799dd9af2f90d71232d
Cr-Commit-Position: refs/heads/master@{#383243}