Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issue 1832913003: Don't focus the location bar in a phishy situation. (Closed)

Created:
4 years, 9 months ago by Charlie Reis
Modified:
4 years, 9 months ago
Reviewers:
palmer
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

Don't focus the location bar in a phishy situation. There is logic to focus the location bar for editing if the URL is about:blank. However, if the page transition type is PAGE_TRANSITION_LINK, bypass that logic; it's not really a blank page. This avoids a phishy edge case with window.open. TBR=palmer BUG=567445 NOTRY=true NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1678233003 Cr-Commit-Position: refs/heads/master@{#379396} (cherry picked from commit c70cb1fe9303df33b11187d0f5f60d22938e6e63)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -2 lines) Patch
M chrome/browser/ui/browser_focus_uitest.cc View 1 chunk +25 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +21 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1832913003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1832913003/1
4 years, 9 months ago (2016-03-24 23:17:16 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-24 23:18:31 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698