Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 1832913002: PlzNavigate: allow the embedder to cancel a transferring navigation (Closed)

Created:
4 years, 9 months ago by clamy
Modified:
4 years, 8 months ago
Reviewers:
nasko
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, carlosk
Base URL:
https://chromium.googlesource.com/chromium/src.git@content-browsertests-2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PlzNavigate: allow the embedder to cancel a transferring navigation This CL allows the WebContents embedder to cancel a navigation that initiated in a renderer but that should commit in a different one (ie a transferring navigation). BUG=475027 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/3ee6a23e4a45b3c089f08ba46130708b0004f255 Cr-Commit-Position: refs/heads/master@{#383713}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M content/browser/frame_host/navigation_request.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M testing/buildbot/filters/browser-side-navigation.linux.content_browsertests.filter View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 16 (9 generated)
clamy
@nasko: PTAL
4 years, 9 months ago (2016-03-24 17:03:43 UTC) #4
nasko
LGTM
4 years, 9 months ago (2016-03-25 21:51:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1832913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1832913002/1
4 years, 9 months ago (2016-03-25 21:53:16 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_gn/builds/9502) ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 9 months ago (2016-03-25 21:55:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1832913002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1832913002/20001
4 years, 8 months ago (2016-03-29 12:28:18 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-29 13:51:04 UTC) #14
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 13:52:50 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3ee6a23e4a45b3c089f08ba46130708b0004f255
Cr-Commit-Position: refs/heads/master@{#383713}

Powered by Google App Engine
This is Rietveld 408576698