Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2291)

Unified Diff: content/browser/cache_storage/cache_storage.h

Issue 1832863002: [CacheStorage] Make CacheStorage::MatchAllCaches return in order (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add layout test Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/cache_storage/cache_storage.h
diff --git a/content/browser/cache_storage/cache_storage.h b/content/browser/cache_storage/cache_storage.h
index aed53b643ab41bb65e1f53b739c191fcc2eddd25..e162abeda98c849f1883077c44268b7e0a84462f 100644
--- a/content/browser/cache_storage/cache_storage.h
+++ b/content/browser/cache_storage/cache_storage.h
@@ -108,10 +108,10 @@ class CONTENT_EXPORT CacheStorage {
private:
friend class TestCacheStorage;
-
+ class CacheLoader;
class MemoryLoader;
class SimpleCacheLoader;
- class CacheLoader;
+ struct CacheMatchResponse;
typedef std::map<std::string, base::WeakPtr<CacheStorageCache>> CacheMap;
@@ -178,14 +178,16 @@ class CONTENT_EXPORT CacheStorage {
// The MatchAllCaches callbacks are below.
void MatchAllCachesImpl(scoped_ptr<ServiceWorkerFetchRequest> request,
const CacheStorageCache::ResponseCallback& callback);
- void MatchAllCachesDidMatch(scoped_refptr<CacheStorageCache> cache,
- const base::Closure& barrier_closure,
- CacheStorageCache::ResponseCallback* callback,
- CacheStorageError error,
- scoped_ptr<ServiceWorkerResponse> response,
- scoped_ptr<storage::BlobDataHandle> handle);
+ void MatchAllCachesDidMatch(
+ scoped_refptr<CacheStorageCache> cache,
+ CacheMatchResponse* out_match_response,
+ const base::Closure& barrier_closure,
+ CacheStorageError error,
+ scoped_ptr<ServiceWorkerResponse> service_worker_response,
+ scoped_ptr<storage::BlobDataHandle> handle);
void MatchAllCachesDidMatchAll(
- scoped_ptr<CacheStorageCache::ResponseCallback> callback);
+ scoped_ptr<std::vector<CacheMatchResponse>> match_responses,
+ const CacheStorageCache::ResponseCallback& callback);
void GetSizeThenCloseAllCachesImpl(const SizeCallback& callback);

Powered by Google App Engine
This is Rietveld 408576698