chrome/browser/external_protocol/external_protocol_handler_unittest.cc - Issue 1832853003: DefaultBrowserWorker now fully supports opening the settings for Win10

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/external_protocol/external_protocol_handler_unittest.cc

Issue 1832853003: DefaultBrowserWorker now fully supports opening the settings for Win10 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix mac compilation Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc ('k') | chrome/browser/first_run/first_run.cc » ('j') | chrome/browser/shell_integration.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/external_protocol/external_protocol_handler_unittest.cc

diff --git a/chrome/browser/external_protocol/external_protocol_handler_unittest.cc b/chrome/browser/external_protocol/external_protocol_handler_unittest.cc

index 0a2ac2941aa8afc1e0d1560564d9b5cd38d06657..41703eef035e67f5ad58520f0c1ccd20409d929a 100644

--- a/chrome/browser/external_protocol/external_protocol_handler_unittest.cc

+++ b/chrome/browser/external_protocol/external_protocol_handler_unittest.cc

@@ -27,7 +27,9 @@ class FakeExternalProtocolHandlerWorker

return os_state_;

}

- void SetAsDefaultImpl() override {}

+ void SetAsDefaultImpl(const base::Closure& on_finished_callback) override {

+ on_finished_callback.Run();

+ }

shell_integration::DefaultWebClientState os_state_;

};