Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4082)

Unified Diff: chrome/browser/chrome_browser_main.cc

Issue 1832853003: DefaultBrowserWorker now fully supports opening the settings for Win10 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix mac compilation Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chrome_browser_main.cc
diff --git a/chrome/browser/chrome_browser_main.cc b/chrome/browser/chrome_browser_main.cc
index 27e12cc24b048008771c20abdb4e4f272f650d10..5fd3d13bcecf419f0ae900136b6c89c63ef36a66 100644
--- a/chrome/browser/chrome_browser_main.cc
+++ b/chrome/browser/chrome_browser_main.cc
@@ -1459,10 +1459,11 @@ int ChromeBrowserMainParts::PreMainMessageLoopRunImpl() {
return chrome::RESULT_CODE_NORMAL_EXIT_EXP2;
// At this point the user is willing to try chrome again.
if (answer == TryChromeDialogView::TRY_CHROME_AS_DEFAULT) {
- // Only set in the unattended case, the interactive case is Windows 8.
- if (shell_integration::CanSetAsDefaultBrowser() ==
- shell_integration::SET_DEFAULT_UNATTENDED)
+ // Only set in the unattended case. This is not true on Windows 8+.
+ if (shell_integration::GetDefaultWebClientSetPermission() ==
+ shell_integration::SET_DEFAULT_UNATTENDED) {
shell_integration::SetAsDefaultBrowser();
+ }
}
#else
// We don't support retention experiments on Mac or Linux.
« no previous file with comments | « no previous file | chrome/browser/custom_handlers/protocol_handler_registry.cc » ('j') | chrome/browser/shell_integration.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698