Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(818)

Issue 1832843002: Add a mb config to android_cronet_tester trybot (Closed)

Created:
4 years, 9 months ago by xunjieli
Modified:
4 years, 9 months ago
CC:
chromium-reviews, mef
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a mb config to android_cronet_tester trybot BUG=597596 Committed: https://crrev.com/2a56b36b8744bdf0ce95eadce89e14e55c5af971 Cr-Commit-Position: refs/heads/master@{#383099}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Sort #

Total comments: 2

Patch Set 3 : Omit arm #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M tools/mb/mb_config.pyl View 1 2 4 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
xunjieli
PTAL.
4 years, 9 months ago (2016-03-24 14:08:31 UTC) #2
jbudorick
https://codereview.chromium.org/1832843002/diff/1/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/1832843002/diff/1/tools/mb/mb_config.pyl#newcode649 tools/mb/mb_config.pyl:649: 'android_cronet_tester': 'android_cronet_gyp_debug_trybot', nit: alphabetize https://codereview.chromium.org/1832843002/diff/1/tools/mb/mb_config.pyl#newcode852 tools/mb/mb_config.pyl:852: 'android_cronet_gyp_debug_trybot': [ nit: ...
4 years, 9 months ago (2016-03-24 15:24:21 UTC) #4
xunjieli
https://codereview.chromium.org/1832843002/diff/1/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/1832843002/diff/1/tools/mb/mb_config.pyl#newcode649 tools/mb/mb_config.pyl:649: 'android_cronet_tester': 'android_cronet_gyp_debug_trybot', On 2016/03/24 15:24:21, jbudorick wrote: > nit: ...
4 years, 9 months ago (2016-03-24 15:56:43 UTC) #5
Dirk Pranke
lgtm w/ one change. https://codereview.chromium.org/1832843002/diff/20001/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/1832843002/diff/20001/tools/mb/mb_config.pyl#newcode870 tools/mb/mb_config.pyl:870: 'android', 'cronet', 'gyp', 'debug_trybot', 'arm' ...
4 years, 9 months ago (2016-03-24 16:07:11 UTC) #6
xunjieli
Thanks! https://codereview.chromium.org/1832843002/diff/20001/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/1832843002/diff/20001/tools/mb/mb_config.pyl#newcode870 tools/mb/mb_config.pyl:870: 'android', 'cronet', 'gyp', 'debug_trybot', 'arm' On 2016/03/24 16:07:11, ...
4 years, 9 months ago (2016-03-24 16:20:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1832843002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1832843002/40001
4 years, 9 months ago (2016-03-24 16:34:50 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-24 18:15:33 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-24 18:17:11 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2a56b36b8744bdf0ce95eadce89e14e55c5af971
Cr-Commit-Position: refs/heads/master@{#383099}

Powered by Google App Engine
This is Rietveld 408576698