Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 1832753002: Add SK_IGNORE_MAC_FONT_WEIGHT_FIX to prepare for rebaseline. (Closed)

Created:
4 years, 9 months ago by bungeman-chromium
Modified:
4 years, 9 months ago
Reviewers:
f(malita)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add SK_IGNORE_MAC_FONT_WEIGHT_FIX to prepare for rebaseline. Skia is changing the way it draws glyphs on Mac to fix several issues. However, this will mean low bit changes in most anti-aliased text in layout tests. This define will keep the old behavior for the time being so that the enablement and rebaseline can happen at the same time. See https://codereview.chromium.org/1827963002/ for the Skia change. TBR=fmalita@chromium.org This just adds a define to the build which is unused until Skia rolls. Committed: https://crrev.com/4094236725f3755f981c4ed2355e4cf71a0a80de Cr-Commit-Position: refs/heads/master@{#383034}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M skia/skia_common.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1832753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1832753002/1
4 years, 9 months ago (2016-03-24 04:14:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1832753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1832753002/1
4 years, 9 months ago (2016-03-24 04:23:52 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-24 05:29:07 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-24 05:30:39 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4094236725f3755f981c4ed2355e4cf71a0a80de
Cr-Commit-Position: refs/heads/master@{#383034}

Powered by Google App Engine
This is Rietveld 408576698