Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Unified Diff: sdk/lib/_internal/lib/js_mirrors.dart

Issue 183273005: Fix wrong type annotation. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/lib/js_mirrors.dart
diff --git a/sdk/lib/_internal/lib/js_mirrors.dart b/sdk/lib/_internal/lib/js_mirrors.dart
index 22e12326a771fbd6e1bf1d18719b6847a668cc20..4b46cb21c990321c060762188845559effa11e2e 100644
--- a/sdk/lib/_internal/lib/js_mirrors.dart
+++ b/sdk/lib/_internal/lib/js_mirrors.dart
@@ -1920,13 +1920,14 @@ class JsClassMirror extends JsTypeMirror with JsObjectMirror
bool get isAbstract => throw new UnimplementedError();
- bool isSubclassOf(JsClassMirror other) {
+ bool isSubclassOf(ClassMirror other) {
if (other is! ClassMirror) {
throw new ArgumentError(other);
}
if (other is JsFunctionTypeMirror) {
return false;
- } if (JS('bool', '# == #', other._jsConstructor, _jsConstructor)) {
+ } if (other is JsClassMirror &&
+ JS('bool', '# == #', other._jsConstructor, _jsConstructor)) {
return true;
} else if (superclass == null) {
return false;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698