Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1832723002: 🌵 Fix ninja warning: multiple rules generate bin/install_unittests_apk_incremental (Closed)

Created:
4 years, 9 months ago by agrieve
Modified:
4 years, 8 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix ninja warning: multiple rules generate bin/install_unittests_apk_incremental BUG=554660 Committed: https://crrev.com/55433a829b02c7574daa217cbf2cff8f6988aa56 Cr-Commit-Position: refs/heads/master@{#383728}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M testing/test.gni View 1 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Issue 1543003005 Patch 1

Messages

Total messages: 12 (5 generated)
agrieve
4 years, 9 months ago (2016-03-24 01:57:41 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1832723002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1832723002/20001
4 years, 9 months ago (2016-03-24 19:03:53 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-24 19:42:28 UTC) #6
brettw
lgtm
4 years, 9 months ago (2016-03-25 22:45:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1832723002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1832723002/20001
4 years, 8 months ago (2016-03-29 14:48:29 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-29 15:26:44 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 15:28:09 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/55433a829b02c7574daa217cbf2cff8f6988aa56
Cr-Commit-Position: refs/heads/master@{#383728}

Powered by Google App Engine
This is Rietveld 408576698