tools/dom/templates/html/impl/impl_XMLHttpRequest.darttemplate - Issue 1832713002: Optimize dartium dart:html bindings so real world application performance is acceptable. Improves d…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dom/templates/html/impl/impl_XMLHttpRequest.darttemplate

Issue 1832713002: Optimize dartium dart:html bindings so real world application performance is acceptable. Improves d… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: update cached patches Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/dom/templates/html/impl/impl_XMLHttpRequest.darttemplate

diff --git a/tools/dom/templates/html/impl/impl_XMLHttpRequest.darttemplate b/tools/dom/templates/html/impl/impl_XMLHttpRequest.darttemplate

index 7ee15d1b3ba9aad98b14a1594a7498eda2585fd8..9ad00f61c2c2053f97c229ee85a0ffa0b1dd0b83 100644

--- a/tools/dom/templates/html/impl/impl_XMLHttpRequest.darttemplate

+++ b/tools/dom/templates/html/impl/impl_XMLHttpRequest.darttemplate

@@ -404,9 +404,9 @@ $endif

$if JSINTEROP

void open(String method, String url, {bool async, String user, String password}) {

if (async == null && user == null && password == null) {

- _blink.BlinkXMLHttpRequest.instance.open_Callback_2_(unwrap_jso(this), method, url);

+ _blink.BlinkXMLHttpRequest.instance.open_Callback_2_(this, method, url);

} else {

- _blink.BlinkXMLHttpRequest.instance.open_Callback_5_(unwrap_jso(this), method, url, async, user, password);

+ _blink.BlinkXMLHttpRequest.instance.open_Callback_5_(this, method, url, async, user, password);

}

$else

« no previous file with comments | « tools/dom/templates/html/impl/impl_WorkerNavigator.darttemplate ('k') | no next file » | no next file with comments »