tools/dom/templates/html/impl/impl_Window.darttemplate - Issue 1832713002: Optimize dartium dart:html bindings so real world application performance is acceptable. Improves d…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dom/templates/html/impl/impl_Window.darttemplate

Issue 1832713002: Optimize dartium dart:html bindings so real world application performance is acceptable. Improves d… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: update cached patches Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/dom/templates/html/impl/impl_WheelEvent.darttemplate ('k') | tools/dom/templates/html/impl/impl_WorkerLocation.darttemplate » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/dom/templates/html/impl/impl_Window.darttemplate

diff --git a/tools/dom/templates/html/impl/impl_Window.darttemplate b/tools/dom/templates/html/impl/impl_Window.darttemplate

index 0b64409772aac93dc6be3cc61f5488a0a2883627..521fd00227357d460b0a10d295ce5ec148b48add 100644

--- a/tools/dom/templates/html/impl/impl_Window.darttemplate

+++ b/tools/dom/templates/html/impl/impl_Window.darttemplate

@@ -297,19 +297,19 @@ $if DART2JS

$else

@DomName('Window.pageXOffset')

@DocsEditable()

- int get pageXOffset => _blink.BlinkWindow.instance.pageXOffset_Getter_(unwrap_jso(this)).round();

+ int get pageXOffset => _blink.BlinkWindow.instance.pageXOffset_Getter_(this).round();

@DomName('Window.pageYOffset')

@DocsEditable()

- int get pageYOffset => _blink.BlinkWindow.instance.pageYOffset_Getter_(unwrap_jso(this)).round();

+ int get pageYOffset => _blink.BlinkWindow.instance.pageYOffset_Getter_(this).round();

@DomName('Window.scrollX')

@DocsEditable()

- int get scrollX => _blink.BlinkWindow.instance.scrollX_Getter_(unwrap_jso(this)).round();

+ int get scrollX => _blink.BlinkWindow.instance.scrollX_Getter_(this).round();

@DomName('Window.scrollY')

@DocsEditable()

- int get scrollY => _blink.BlinkWindow.instance.scrollY_Getter_(unwrap_jso(this)).round();

+ int get scrollY => _blink.BlinkWindow.instance.scrollY_Getter_(this).round();

$endif

}