tools/dom/templates/html/impl/impl_FileReader.darttemplate - Issue 1832713002: Optimize dartium dart:html bindings so real world application performance is acceptable. Improves d…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dom/templates/html/impl/impl_FileReader.darttemplate

Issue 1832713002: Optimize dartium dart:html bindings so real world application performance is acceptable. Improves d… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: update cached patches Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/dom/templates/html/impl/impl_Element.darttemplate ('k') | tools/dom/templates/html/impl/impl_HTMLAudioElement.darttemplate » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/dom/templates/html/impl/impl_FileReader.darttemplate

diff --git a/tools/dom/templates/html/impl/impl_FileReader.darttemplate b/tools/dom/templates/html/impl/impl_FileReader.darttemplate

index ba5278f99ee7f2c8093040fec19860652da6a8e7..d698e375e3811cc26f5dcfab8e7d6ecbec4be19e 100644

--- a/tools/dom/templates/html/impl/impl_FileReader.darttemplate

+++ b/tools/dom/templates/html/impl/impl_FileReader.darttemplate

@@ -13,7 +13,7 @@ $(ANNOTATIONS)$(NATIVESPEC)$(CLASS_MODIFIERS)class $CLASSNAME$EXTENDS$IMPLEMENTS

$if DART2JS

var res = JS('Null|String|NativeByteBuffer', '#.result', this);

$else

- var res = _blink.BlinkFileReader.instance.result_Getter_(unwrap_jso(this));

+ var res = _blink.BlinkFileReader.instance.result_Getter_(this);

$endif

if (res is ByteBuffer) {

return new Uint8List.view(res);