tools/dom/templates/html/impl/impl_CustomEvent.darttemplate - Issue 1832713002: Optimize dartium dart:html bindings so real world application performance is acceptable. Improves d…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dom/templates/html/impl/impl_CustomEvent.darttemplate

Issue 1832713002: Optimize dartium dart:html bindings so real world application performance is acceptable. Improves d… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: update cached patches Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/dom/templates/html/impl/impl_CSSStyleDeclaration.darttemplate ('k') | tools/dom/templates/html/impl/impl_DataTransferItemList.darttemplate » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/dom/templates/html/impl/impl_CustomEvent.darttemplate

diff --git a/tools/dom/templates/html/impl/impl_CustomEvent.darttemplate b/tools/dom/templates/html/impl/impl_CustomEvent.darttemplate

index e16b74a9fe70544719c8c305ed173fd36c9c8a5a..b2a787e4c52dbab31fe37cfa5b90e94b093de074 100644

--- a/tools/dom/templates/html/impl/impl_CustomEvent.darttemplate

+++ b/tools/dom/templates/html/impl/impl_CustomEvent.darttemplate

@@ -23,9 +23,7 @@ $(ANNOTATIONS)$(NATIVESPEC)$(CLASS_MODIFIERS)class $CLASSNAME$EXTENDS$IMPLEMENTS

// first-chance exceptions. Can expand this list in the future as needed.

if (detail is List || detail is Map || detail is String || detail is num) {

try {

-$if DART2JS

detail = convertDartToNative_SerializedScriptValue(detail);

-$endif

e._initCustomEvent(type, canBubble, cancelable, detail);

} catch(_) {

e._initCustomEvent(type, canBubble, cancelable, null);

@@ -34,11 +32,6 @@ $endif

e._initCustomEvent(type, canBubble, cancelable, null);

}

-$if DARTIUM

- // Need for identity.

- js.setDartHtmlWrapperFor(e.blink_jsObject, e);

-$endif

return e;

}