tools/dom/templates/html/impl/impl_SVGElement.darttemplate - Issue 1832713002: Optimize dartium dart:html bindings so real world application performance is acceptable. Improves d…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dom/templates/html/impl/impl_SVGElement.darttemplate

Issue 1832713002: Optimize dartium dart:html bindings so real world application performance is acceptable. Improves d… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: update cached patches Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/dom/templates/html/impl/impl_SVGCursorElement.darttemplate ('k') | tools/dom/templates/html/impl/impl_SVGFEDropShadowElement.darttemplate » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/dom/templates/html/impl/impl_SVGElement.darttemplate

diff --git a/tools/dom/templates/html/impl/impl_SVGElement.darttemplate b/tools/dom/templates/html/impl/impl_SVGElement.darttemplate

index b41f7eca2eb7beb0256dd4c7e7b8c02972bcb6f5..fec3eb6a87d8615f8e9a705f41ef1cd3c442c979 100644

--- a/tools/dom/templates/html/impl/impl_SVGElement.darttemplate

+++ b/tools/dom/templates/html/impl/impl_SVGElement.darttemplate

@@ -146,18 +146,8 @@ $(ANNOTATIONS)$(NATIVESPEC)$(CLASS_MODIFIERS)class $CLASSNAME$EXTENDS$IMPLEMENTS

$if JSINTEROP

set _svgClassName(AnimatedString value) =>

- _blink.BlinkSVGElement.instance.className_Setter_(unwrap_jso(this), unwrap_jso(value));

+ _blink.BlinkSVGElement.instance.className_Setter_(this, value);

- String get className => _svgClassName.baseVal;

- // Unbelievable hack. We can't create an SvgAnimatedString, but we can get

- // the existing one and change its baseVal. Then we call the blink setter directly

- // TODO(alanknight): Handle suppressing the SVGAnimated<*> better

- set className(String s) {

- var oldClass = _svgClassName;

- oldClass.baseVal = s;

- _svgClassName = oldClass;

- }

$endif

$!MEMBERS

}