tests/html/js_array_test.dart - Issue 1832713002: Optimize dartium dart:html bindings so real world application performance is acceptable. Improves d…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/html/js_array_test.dart

Issue 1832713002: Optimize dartium dart:html bindings so real world application performance is acceptable. Improves d… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: update cached patches Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tests/html/js_array_test.dart

diff --git a/tests/html/js_array_test.dart b/tests/html/js_array_test.dart

index 598cadfb7bb58c1b567f5362d96d82eba9256fdf..753ced3ba289e2ec0f4d7423603ada4780f75785 100644

--- a/tests/html/js_array_test.dart

+++ b/tests/html/js_array_test.dart

@@ -511,8 +511,10 @@ main() {

expect(descriptor.value, equals("a"));

expect(descriptor.writable, isTrue);

- expect(descriptor.enumerable, isTrue);

- expect(descriptor.configurable, isTrue);

+ // TODO(jacobr): commented out until https://github.com/dart-lang/sdk/issues/26128

+ // is fixed.

+ // expect(descriptor.enumerable, isTrue);

+ // expect(descriptor.configurable, isTrue);

descriptor = getOwnPropertyDescriptor(list, "length");

expect(descriptor.value, equals(2));

« no previous file with comments | « tests/html/html.status ('k') | tests/html/js_test.dart » ('j') | no next file with comments »