tools/dom/scripts/css_code_generator.py - Issue 1832713002: Optimize dartium dart:html bindings so real world application performance is acceptable. Improves d…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dom/scripts/css_code_generator.py

Issue 1832713002: Optimize dartium dart:html bindings so real world application performance is acceptable. Improves d… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sdk/lib/html/html_common/conversions_dartium.dart ('K') | « tools/dom/dom.json ('k') | tools/dom/scripts/generate_blink_file.py » ('j') | tools/dom/src/native_DOMImplementation.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/dom/scripts/css_code_generator.py

diff --git a/tools/dom/scripts/css_code_generator.py b/tools/dom/scripts/css_code_generator.py

index 74de8e4285a19d2691abc04b961c0c90289f844a..b31d18ef3e5a7a8ee8e1446354c586b9cbecb2f0 100644

--- a/tools/dom/scripts/css_code_generator.py

+++ b/tools/dom/scripts/css_code_generator.py

@@ -154,7 +154,7 @@ $endif

$if DARTIUM

bool _hasProperty(String propertyName) =>

$if JSINTEROP

- _blink.BlinkCSSStyleDeclaration.instance.$__propertyQuery___Callback_1_(unwrap_jso(this), propertyName) != null;

+ _blink.BlinkCSSStyleDeclaration.instance.$__propertyQuery___Callback_1_(this, propertyName) != null;

$else

_blink.BlinkCSSStyleDeclaration.$__propertyQuery___Callback_1(this, propertyName);

$endif

« sdk/lib/html/html_common/conversions_dartium.dart ('K') | « tools/dom/dom.json ('k') | tools/dom/scripts/generate_blink_file.py » ('j') | tools/dom/src/native_DOMImplementation.dart » ('J')