Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: tools/dom/src/dartium_KeyEvent.dart

Issue 1832713002: Optimize dartium dart:html bindings so real world application performance is acceptable. Improves d… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: update cached patches Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /** 1 /**
2 * A custom KeyboardEvent that attempts to eliminate cross-browser 2 * A custom KeyboardEvent that attempts to eliminate cross-browser
3 * inconsistencies, and also provide both keyCode and charCode information 3 * inconsistencies, and also provide both keyCode and charCode information
4 * for all key events (when such information can be determined). 4 * for all key events (when such information can be determined).
5 * 5 *
6 * KeyEvent tries to provide a higher level, more polished keyboard event 6 * KeyEvent tries to provide a higher level, more polished keyboard event
7 * information on top of the "raw" [KeyboardEvent]. 7 * information on top of the "raw" [KeyboardEvent].
8 * 8 *
9 * The mechanics of using KeyEvents is a little different from the underlying 9 * The mechanics of using KeyEvents is a little different from the underlying
10 * [KeyboardEvent]. To use KeyEvents, you need to create a stream and then add 10 * [KeyboardEvent]. To use KeyEvents, you need to create a stream and then add
(...skipping 12 matching lines...) Expand all
23 * 23 *
24 * This class is very much a work in progress, and we'd love to get information 24 * This class is very much a work in progress, and we'd love to get information
25 * on how we can make this class work with as many international keyboards as 25 * on how we can make this class work with as many international keyboards as
26 * possible. Bugs welcome! 26 * possible. Bugs welcome!
27 */ 27 */
28 part of html; 28 part of html;
29 29
30 @Experimental() 30 @Experimental()
31 class KeyEvent extends _WrappedEvent implements KeyboardEvent { 31 class KeyEvent extends _WrappedEvent implements KeyboardEvent {
32 /** Needed because KeyboardEvent is implements. 32 /** Needed because KeyboardEvent is implements.
33 * TODO(terry): Consider making blink_jsObject private (add underscore) for
34 * all blink_jsObject. Then needed private wrap/unwrap_jso
35 * functions that delegate to a public wrap/unwrap_jso.
36 */ 33 */
37 @Deprecated("Internal Use Only")
38 js.JsObject blink_jsObject;
39
40 /** The parent KeyboardEvent that this KeyEvent is wrapping and "fixing". */ 34 /** The parent KeyboardEvent that this KeyEvent is wrapping and "fixing". */
41 KeyboardEvent _parent; 35 KeyboardEvent _parent;
42 36
43 /** The "fixed" value of whether the alt key is being pressed. */ 37 /** The "fixed" value of whether the alt key is being pressed. */
44 bool _shadowAltKey; 38 bool _shadowAltKey;
45 39
46 /** Calculated value of what the estimated charCode is for this event. */ 40 /** Calculated value of what the estimated charCode is for this event. */
47 int _shadowCharCode; 41 int _shadowCharCode;
48 42
49 /** Calculated value of what the estimated keyCode is for this event. */ 43 /** Calculated value of what the estimated keyCode is for this event. */
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
146 "Cannot initialize a KeyboardEvent from a KeyEvent."); 140 "Cannot initialize a KeyboardEvent from a KeyEvent.");
147 } 141 }
148 @Experimental() // untriaged 142 @Experimental() // untriaged
149 bool getModifierState(String keyArgument) => throw new UnimplementedError(); 143 bool getModifierState(String keyArgument) => throw new UnimplementedError();
150 @Experimental() // untriaged 144 @Experimental() // untriaged
151 int get location => throw new UnimplementedError(); 145 int get location => throw new UnimplementedError();
152 @Experimental() // untriaged 146 @Experimental() // untriaged
153 bool get repeat => throw new UnimplementedError(); 147 bool get repeat => throw new UnimplementedError();
154 dynamic get _get_view => throw new UnimplementedError(); 148 dynamic get _get_view => throw new UnimplementedError();
155 } 149 }
OLDNEW
« no previous file with comments | « tools/dom/src/dartium_CustomElementSupport.dart ('k') | tools/dom/src/dartium_WrappedEvent.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698