Optimize dartium dart:html bindings so real world application performance is acceptable. Improves d…

tests/html/js_test.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library jsTest;
 
 import 'dart:async';
 import 'dart:html';
 import 'dart:typed_data' show ByteBuffer, Int32List;
 import 'dart:indexed_db' show IdbFactory, KeyRange;
@@ skipping 222 matching lines @@
   useHtmlIndividualConfiguration();
 
   group('identity', () {
 
     test('context instances should be identical', () {
       var c1 = context;
       var c2 = context;
       expect(identical(c1, c2), isTrue);
     });
 
-  /*
-    TODO(jacobr): enable this test when dartium supports maintaining proxy
-    equality.
-
     test('identical JS objects should have identical proxies', () {
       var o1 = new JsObject(context['Foo'], [1]);
       context['f1'] = o1;
       var o2 = context['f1'];
-      expect(equals(o1, o2), isTrue);
+      expect(identical(o1, o2), isTrue);
     });
 
+/*
+ TODO(jacobr): enable this test when dartium supports maintaining proxy
+    equality.
     test('identical Dart objects should have identical proxies', () {
       var o1 = new TestDartObject();
       expect(context.callMethod('identical', [o1, o1]), isTrue);
     });
+    */
 
     test('identical Dart functions should have identical proxies', () {
-      var f1 = () => print("I'm a Function!");
+      var f1 = allowInterop(() => print("I'm a Function!"));
       expect(context.callMethod('identical', [f1, f1]), isTrue);
     });
-    */
 
-    // TODO(jacobr): switch from equals to indentical when dartium supports
-    // maintaining proxy equality.
-    test('identical JS functions should have equal proxies', () {
+    test('identical JS functions should have identical proxies', () {
       var f1 = context['Object'];
       var f2 = context['Object'];
-      expect(f1, equals(f2));
+      expect(identical(f1, f2), isTrue);
     });
 
     // TODO(justinfagnani): old tests duplicate checks above, remove
     // on test next cleanup pass
     test('test proxy equality', () {
       var foo1 = new JsObject(context['Foo'], [1]);
       var foo2 = new JsObject(context['Foo'], [2]);
       context['foo1'] = foo1;
       context['foo2'] = foo2;
       expect(foo1, isNot(equals(context['foo2'])));
@@ skipping 166 matching lines @@
 
     test('new JsObject can return a JsFunction', () {
       var f = new JsObject(context['Function']);
       expect(f, new isInstanceOf<JsFunction>());
     });
 
     test('JsFunction.apply on a function defined in JS', () {
       expect(context['razzle'].apply([]), equals(42));
     });
 
-    test('JsFunction.apply on a function that uses "this"', () {
+    test('JsFunction.apply on a function that uses this', () {
       var object = new Object();
       expect(context['returnThis'].apply([], thisArg: object), same(object));
     });
 
     test('JsObject.callMethod on a function defined in JS', () {
       expect(context.callMethod('razzle'), equals(42));
       expect(() => context.callMethod('dazzle'), throwsA(isNoSuchMethodError));
     });
 
     test('callMethod with many arguments', () {
@@ skipping 42 matching lines @@
           ['a', context['Array']]), isTrue);
       var a = context['a'];
       expect(a, new isInstanceOf<JsArray>());
       expect(a, [1, 2, 3]);
       context.deleteProperty('a');
     });
 
     test('pass Array to JS', () {
       context['a'] = [1, 2, 3];
       expect(context.callMethod('isPropertyInstanceOf',
-          ['a', context['Array']]), isFalse);
+          ['a', context['Array']]), isTrue);
       var a = context['a'];
       expect(a, new isInstanceOf<List>());
       expect(a, isNot(new isInstanceOf<JsArray>()));
       expect(a, [1, 2, 3]);
       context.deleteProperty('a');
     });
 
     test('[]', () {
       var array = new JsArray.from([1, 2]);
       expect(array[0], 1);
@@ skipping 477 matching lines @@
           // expect(context.callMethod('isPropertyInstanceOf', ['o', listType]),
           //    isTrue);
           context.deleteProperty('o');
         }
       });
 
     });
   });
 
 }