Optimize dartium dart:html bindings so real world application performance is acceptable. Improves d…

tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // WARNING: Do not edit - generated code.
 
 part of $LIBRARYNAME;
 
 $(ANNOTATIONS)$(NATIVESPEC)$(CLASS_MODIFIERS)class $CLASSNAME$EXTENDS$IMPLEMENTS {
 $!MEMBERS
@@ skipping 395 matching lines @@
       //
       //     var myProto = Object.create(HTMLElement.prototype);
       //     var myElement = document.registerElement('x-foo', {prototype: myProto});
       var baseElement = js.JsNative.getProperty(js.context, jsClassName);
       if (baseElement == null) {
         // Couldn't find the HTML element so use a generic one.
         baseElement = js.JsNative.getProperty(js.context, 'HTMLElement');
       }
       var elemProto = js.JsNative.callMethod(js.JsNative.getProperty(js.context, 'Object'), "create", [js.JsNative.getProperty(baseElement, 'prototype')]);
 
-      // Remember for any upgrading done in wrap_jso.
       addCustomElementType(tag, customElementClass, extendsTag);
 
       // TODO(terry): Hack to stop recursion re-creating custom element when the
       //              created() constructor of the custom element does e.g.,
       //
       //                  MyElement.created() : super.created() {
       //                    this.innerHtml = "<b>I'm an x-foo-with-markup!</b>";
       //                  }
       //
       //              sanitizing causes custom element to created recursively
       //              until stack overflow.
       //
       //              See https://github.com/dart-lang/sdk/issues/23666
       int creating = 0;
 
       // If any JS code is hooked we want to call it too.
-      var oldCreatedCallback = elemProto['createdCallback'];
-      var oldAttributeChangedCallback = elemProto['attributeChangedCallback'];
-      var oldAttachedCallback = elemProto['attachedCallback'];
-      var oldDetachedCallback = elemProto['detachedCallback'];
+      var oldCreatedCallback = js.JsNative.getProperty(elemProto, 'createdCallback');
+      var oldAttributeChangedCallback = js.JsNative.getProperty(elemProto, 'attributeChangedCallback');
+      var oldAttachedCallback = js.JsNative.getProperty(elemProto, 'attachedCallback');
+      var oldDetachedCallback = js.JsNative.getProperty(elemProto, 'detachedCallback');
 
-      // TODO(jacobr): warning:
-      elemProto['createdCallback'] = js.JsNative.withThis(($this) {
+      // TODO(jacobr): this code seems far more complex than it should be
+      // unless I am missing something.
+      js.JsNative.setProperty(elemProto, 'createdCallback', js.allowInteropCaptureThis(($this) {
         if (_getJSClassName(reflectClass(customElementClass).superclass) != null && creating < 2) {
           creating++;
 
           var dartClass;
           try {
             if (extendsTag != null) {
               // If we're extending a native element then create that element.
               // Then upgrade that element to the customElementClass through
               // normal flow.
               dartClass = document.createElement(extendsTag);
-              js.setDartHtmlWrapperFor($this, dartClass);
-              dartClass.blink_jsObject = $this;
+              // TODO(jacobr): THIS MAKES NO SENSE. WAAT?
+
+              $this = js.JsNative.$setInstanceInterceptor($this, dartClass.runtimeType);
+              dartClass = $this; // THIS IS CRAZY CODE CODE BUT IT MATCHES WHAT HAD. WTH.. THIS CODE JUST SEEMS WRONG.
             }
 
             // Upgrade to the CustomElement Dart class.
             dartClass = _blink.Blink_Utils.constructElement(customElementClass, $this);
           } catch (e) {
             // Got a problem make it an HtmlElement and rethrow the error.
-            dartClass = HtmlElement.internalCreateHtmlElement();
-            // We need to remember the JS object (because constructElement failed
-            // it normally sets up the blink_jsObject.
-            dartClass.blink_jsObject = $this;
+            dartClass = js.JsNative.$setInstanceInterceptor($this, new HtmlElement.internalCreateHtmlElement().runtimeType);
 
             // Mark to only try this once don't try upgrading from HtmlElement
             // to the user's Dart class - we had a problem.
             dartClass._badUpgrade();
             throw e;
           } finally {
             // Need to remember the Dart class that was created for this custom so
             // return it and setup the blink_jsObject to the $this that we'll be working
             // with as we talk to blink.
             js.setDartHtmlWrapperFor($this, dartClass);
-
+            // TODO(jacobr) THIS MAKES NO SENSE BUT MATCHES WHAT WE HAD BEFORE.
+            js.JsNative.$setInstanceInterceptor($this, dartClass.runtimeType);
             creating--;
           }
         }
 
         if (oldCreatedCallback != null)
-          oldCreatedCallback.apply([], thisArg: unwrap_jso($this));
-      });
-      elemProto['attributeChangedCallback'] = new js.JsFunction.withThis(($this, attrName, oldVal, newVal) {
+          oldCreatedCallback.apply([], thisArg: $this);
+      }));
+      js.JsNative.setProperty(elemProto, 'attributeChangedCallback', js.allowInteropCaptureThis(($this, attrName, oldVal, newVal) {
         $this.attributeChanged(attrName, oldVal, newVal);
 
         if (oldAttributeChangedCallback != null)
-          oldAttributeChangedCallback.apply([], thisArg: unwrap_jso($this));
-      });
-      elemProto['attachedCallback'] = new js.JsFunction.withThis(($this) {
+          oldAttributeChangedCallback.apply([], thisArg: $this);
+      }));
+      js.JsNative.setProperty(elemProto, 'attachedCallback', js.allowInteropCaptureThis(($this) {
         $this.attached();
 
         if (oldAttachedCallback != null)
-          oldAttachedCallback.apply([], thisArg: unwrap_jso($this));
-      });
-      elemProto['detachedCallback'] = new js.JsFunction.withThis(($this) {
+          oldAttachedCallback.apply([], thisArg: $this);
+      }));
+      js.JsNative.setProperty(elemProto, 'detachedCallback', js.allowInteropCaptureThis(($this) {
         $this.detached();
 
         if (oldDetachedCallback != null)
-          oldDetachedCallback.apply([], thisArg: unwrap_jso($this));
-      });
+          oldDetachedCallback.apply([], thisArg: $this);
+      }));
       // document.registerElement('x-foo', {prototype: elemProto, extends: extendsTag});
       var jsMap = new js.JsObject.jsify({'prototype': elemProto, 'extends': extendsTag});
-      js.JsNative.callMethod(js.JsNative.getProperty(js.context, 'document'), 'registerElement', [tag, jsMap]);
+      js.JsNative.callMethod(document, 'registerElement', [tag, jsMap]);
     }
 $endif
   }
 
   /** *Deprecated*: use [registerElement] instead. */
   @deprecated
   @Experimental()
   void register(String tag, Type customElementClass, {String extendsTag}) {
     return registerElement(tag, customElementClass, extendsTag: extendsTag);
   }
@@ skipping 48 matching lines @@
   /// parameter must be provided.
   @Experimental()
   ElementUpgrader createElementUpgrader(Type type, {String extendsTag}) {
 $if DART2JS
     return new _JSElementUpgrader(this, type, extendsTag);
 $else
     return new _VMElementUpgrader(this, type, extendsTag);
 $endif
   }
 }