Optimize dartium dart:html bindings so real world application performance is acceptable. Improves d…

tools/dom/templates/html/dartium/html_dartium.darttemplate

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // DO NOT EDIT
 // Auto-generated dart:html library.
 
 /**
  * HTML elements and other resources for web-based applications that need to
  * interact with the browser and the DOM (Document Object Model).
@@ skipping 100 matching lines @@
  * See also:
  *
  *   * [Window](https://developer.mozilla.org/en-US/docs/Web/API/window) from MDN.
  */
 Window get window {
   if (_window != null) {
     return _window;
   }
 $if DARTIUM
 $if JSINTEROP
-  _window = wrap_jso(js.JsNative.getProperty(js.context, 'window'));
+  _window = js.JsNative.toTypedObject(js.context);
 $else
   _window = _Utils.window();
 $endif
 $endif
   return _window;
 }
 
 HtmlDocument _document;
 
 /**
@@ skipping 22 matching lines @@
 @Deprecated("Internal Use Only")
 final htmlBlinkMap = {
   '_HistoryCrossFrame': () => _HistoryCrossFrame,
   '_LocationCrossFrame': () => _LocationCrossFrame,
   '_DOMWindowCrossFrame': () => _DOMWindowCrossFrame,
   // FIXME: Move these to better locations.
   'DateTime': () => DateTime,
   'JsObject': () => js.JsObject,
   'JsFunction': () => js.JsFunction,
   'JsArray': () => js.JsArray,
+  // We have to call .instanceRuntimeType as these classes have a private
+  // implementation class defined dynamically at runtime via a patch file.
+  'JSObject': () => js.JSObject.instanceRuntimeType,
+  'JSFunction': () => js.JSFunction.instanceRuntimeType,
+  'JSArray': () => js.JSArray.instanceRuntimeType,
 $!TYPE_MAP
 };
 
 // TODO(leafp): We may want to move this elsewhere if html becomes
 // a package to avoid dartium depending on pkg:html.
 Type _getType(String key) {
   var result;
 
   // TODO(vsm): Add Cross Frame and JS types here as well.
 
@@ skipping 236 matching lines @@
   if (!expression) {
     throw new DebugAssertException("$message");
   }
 }
 
 @Deprecated("Internal Use Only")
 Map<String, dynamic> convertNativeObjectToDartMap(js.JsObject jsObject) {
   var result = new Map();
   var keys = js.JsNative.callMethod(js.JsNative.getProperty(js.context, 'Object'), 'keys', [jsObject]);
   for (var key in keys) {
-    result[key] = wrap_jso(js.JsNative.getProperty(jsObject, key));
+    result[key] = js.JsNative.getProperty(jsObject, key);
   }
   return result;
 }
 
 /**
  * Upgrade the JS HTMLElement to the Dart class.  Used by Dart's Polymer.
  */
 _createCustomUpgrader(Type customElementClass, $this) {
   var dartClass;
+  throw 'TODO(jacobr): implement _createCustomUpgrader';
   try {
     dartClass = _blink.Blink_Utils.constructElement(customElementClass, $this);
   } catch (e) {
     // Did the dartClass get allocated but the created failed?  Otherwise, other
     // components inside of this failed somewhere (could be JS custom element).
+    // TODO(jacobr): clearly this can't happen otherwise an exception wouldn't

[Alan Knight, 2016/03/25 21:39:09]

I think I remember Terry introducing this because of the case where a user's
custom element constructor throws an exception. But I may be wrong or thinking
of something else.

[Jacob, 2016/03/30 00:19:00]

This code path is now obsolete. I've rewritten all the custom element support in
this CL so it actually works(tm). Generally, code flow is now simpler as
"upgrading" can happen a bit earlier as it has to happen more in C++ code given
we need to invoke the  created constructor immediately after creating an
instance.
C++ code now dispatches an error on failed upgrades and falls back to
HTMLElement.

+    // have been thrown. This code needs to be carefully reviewed.
     if (dartClass != null) {
       // Yes, mark as didn't upgrade.
       dartClass._badUpgrade();
     }
     throw e;
   } finally {
     // Need to remember the Dart class that was created for this custom so
     // return it and setup the blink_jsObject to the $this that we'll be working
     // with as we talk to blink.
-    js.setDartHtmlWrapperFor($this, dartClass);
+    // XXX terry, what do we need to do for this code?
+    print("XXX VALIDATE THIS CASE WORKS");
+    // XXX THIS IS ALL KINDS OF FOOBAR.
+    // js.setDartHtmlWrapperFor($this, dartClass);
   }
 
   return dartClass;
 }
 
 $else
 class DartHtmlDomObject extends NativeFieldWrapperClass2 {}
 
 _createCustomUpgrader(Type customElementClass, $this) => $this;
 
 $endif