Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Unified Diff: mojo/public/cpp/bindings/tests/pickle_unittest.cc

Issue 1832703002: Mojo: Simplify typemap usage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojo-bindings-variant-import
Patch Set: add missing mash dependency Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/cpp/bindings/tests/pickle_unittest.cc
diff --git a/mojo/public/cpp/bindings/tests/pickle_unittest.cc b/mojo/public/cpp/bindings/tests/pickle_unittest.cc
index 17b1724bd9757d31e38e26f00e4c3b81ebfe0292..34aec26a962b171f157918d36dc111b3c879ddeb 100644
--- a/mojo/public/cpp/bindings/tests/pickle_unittest.cc
+++ b/mojo/public/cpp/bindings/tests/pickle_unittest.cc
@@ -14,8 +14,8 @@
#include "mojo/public/cpp/bindings/tests/pickled_struct_blink.h"
#include "mojo/public/cpp/bindings/tests/pickled_struct_chromium.h"
#include "mojo/public/cpp/bindings/tests/variant_test_util.h"
-#include "mojo/public/interfaces/bindings/tests/test_native_types.mojom-blink.h"
-#include "mojo/public/interfaces/bindings/tests/test_native_types.mojom-chromium.h"
+#include "mojo/public/interfaces/bindings/tests/test_native_types.mojom-wtf.h"
+#include "mojo/public/interfaces/bindings/tests/test_native_types.mojom.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace mojo {
@@ -54,18 +54,18 @@ void ExpectError(InterfacePtr<T>* proxy, const base::Closure& callback) {
}
// This implements the generated Chromium variant of PicklePasser.
-class ChromiumPicklePasserImpl : public chromium::PicklePasser {
+class ChromiumPicklePasserImpl : public PicklePasser {
public:
ChromiumPicklePasserImpl() {}
- // mojo::test::chromium::PicklePasser:
+ // mojo::test::PicklePasser:
void PassPickle(const PickledStructChromium& pickle,
const PassPickleCallback& callback) override {
callback.Run(pickle);
}
void PassPickleContainer(
- chromium::PickleContainerPtr container,
+ PickleContainerPtr container,
const PassPickleContainerCallback& callback) override {
callback.Run(std::move(container));
}
@@ -82,28 +82,28 @@ class ChromiumPicklePasserImpl : public chromium::PicklePasser {
};
// This implements the generated Blink variant of PicklePasser.
-class BlinkPicklePasserImpl : public blink::PicklePasser {
+class BlinkPicklePasserImpl : public wtf::PicklePasser {
public:
BlinkPicklePasserImpl() {}
- // mojo::test::blink::PicklePasser:
+ // mojo::test::wtf::PicklePasser:
void PassPickle(const PickledStructBlink& pickle,
const PassPickleCallback& callback) override {
callback.Run(pickle);
}
void PassPickleContainer(
- blink::PickleContainerPtr container,
+ wtf::PickleContainerPtr container,
const PassPickleContainerCallback& callback) override {
callback.Run(std::move(container));
}
- void PassPickles(Array<PickledStructBlink> pickles,
+ void PassPickles(WTFArray<PickledStructBlink> pickles,
const PassPicklesCallback& callback) override {
callback.Run(std::move(pickles));
}
- void PassPickleArrays(Array<Array<PickledStructBlink>> pickle_arrays,
+ void PassPickleArrays(WTFArray<WTFArray<PickledStructBlink>> pickle_arrays,
const PassPickleArraysCallback& callback) override {
callback.Run(std::move(pickle_arrays));
}
@@ -115,32 +115,32 @@ class PickleTest : public testing::Test {
public:
PickleTest() {}
- template <typename ProxyType = chromium::PicklePasser>
+ template <typename ProxyType = PicklePasser>
InterfacePtr<ProxyType> ConnectToChromiumService() {
InterfacePtr<ProxyType> proxy;
InterfaceRequest<ProxyType> request = GetProxy(&proxy);
chromium_bindings_.AddBinding(
&chromium_service_,
- ConvertInterfaceRequest<chromium::PicklePasser>(std::move(request)));
+ ConvertInterfaceRequest<PicklePasser>(std::move(request)));
return proxy;
}
- template <typename ProxyType = blink::PicklePasser>
+ template <typename ProxyType = wtf::PicklePasser>
InterfacePtr<ProxyType> ConnectToBlinkService() {
InterfacePtr<ProxyType> proxy;
InterfaceRequest<ProxyType> request = GetProxy(&proxy);
blink_bindings_.AddBinding(
&blink_service_,
- ConvertInterfaceRequest<blink::PicklePasser>(std::move(request)));
+ ConvertInterfaceRequest<wtf::PicklePasser>(std::move(request)));
return proxy;
}
private:
base::MessageLoop loop_;
ChromiumPicklePasserImpl chromium_service_;
- BindingSet<chromium::PicklePasser> chromium_bindings_;
+ BindingSet<PicklePasser> chromium_bindings_;
BlinkPicklePasserImpl blink_service_;
- BindingSet<blink::PicklePasser> blink_bindings_;
+ BindingSet<wtf::PicklePasser> blink_bindings_;
};
} // namespace
@@ -164,7 +164,7 @@ TEST_F(PickleTest, ChromiumProxyToChromiumService) {
}
TEST_F(PickleTest, ChromiumProxyToBlinkService) {
- auto chromium_proxy = ConnectToBlinkService<chromium::PicklePasser>();
+ auto chromium_proxy = ConnectToBlinkService<PicklePasser>();
{
base::RunLoop loop;
chromium_proxy->PassPickle(
@@ -203,7 +203,7 @@ TEST_F(PickleTest, BlinkProxyToBlinkService) {
}
TEST_F(PickleTest, BlinkProxyToChromiumService) {
- auto blink_proxy = ConnectToChromiumService<blink::PicklePasser>();
+ auto blink_proxy = ConnectToChromiumService<wtf::PicklePasser>();
{
base::RunLoop loop;
blink_proxy->PassPickle(
@@ -291,22 +291,20 @@ TEST_F(PickleTest, PickleArrayArray) {
TEST_F(PickleTest, PickleContainer) {
auto proxy = ConnectToChromiumService();
- chromium::PickleContainerPtr pickle_container =
- chromium::PickleContainer::New();
+ PickleContainerPtr pickle_container = PickleContainer::New();
pickle_container->pickle.set_foo(42);
pickle_container->pickle.set_bar(43);
pickle_container->pickle.set_baz(44);
{
base::RunLoop run_loop;
- proxy->PassPickleContainer(
- std::move(pickle_container),
- [&](chromium::PickleContainerPtr passed) {
- ASSERT_FALSE(passed.is_null());
- EXPECT_EQ(42, passed->pickle.foo());
- EXPECT_EQ(43, passed->pickle.bar());
- EXPECT_EQ(0, passed->pickle.baz());
- run_loop.Quit();
- });
+ proxy->PassPickleContainer(std::move(pickle_container),
+ [&](PickleContainerPtr passed) {
+ ASSERT_FALSE(passed.is_null());
+ EXPECT_EQ(42, passed->pickle.foo());
+ EXPECT_EQ(43, passed->pickle.bar());
+ EXPECT_EQ(0, passed->pickle.baz());
+ run_loop.Quit();
+ });
run_loop.Run();
}
}
« no previous file with comments | « mojo/public/cpp/bindings/tests/chromium_typemaps.gni ('k') | mojo/public/cpp/bindings/tests/rect_blink.typemap » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698