gpu/command_buffer/common/capabilities.typemap - Issue 1832703002: Mojo: Simplify typemap usage.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: gpu/command_buffer/common/capabilities.typemap

Issue 1832703002: Mojo: Simplify typemap usage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojo-bindings-variant-import

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # Copyright 2016 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 mojom = "//gpu/command_buffer/common/capabilities.mojom"

	6 public_headers = [ "//gpu/command_buffer/common/capabilities.h" ]

	7 traits_headers = [ "//gpu/ipc/common/gpu_command_buffer_traits.h" ]

	8 deps = [

	9 "//gpu/ipc/common:command_buffer_traits",

	10 ]

	11

	12 type_mappings = [ "gpu.mojom.Capabilities=gpu::Capabilities" ]
	yzshen1 2016/04/05 17:36:14 Does it make sense to use a map instead? Something Does it make sense to use a map instead? Something like: type_mappings = { "gpu.mojom.Capabilities" : "gpu::Capabilities" } I feel that it is easier to read and parse. WDYT? Sam McNally 2016/04/06 07:02:53 I would prefer something more like that, but GN do Show quoted text On 2016/04/05 17:36:14, yzshen1 wrote: > Does it make sense to use a map instead? Something like: > > type_mappings = { "gpu.mojom.Capabilities" : "gpu::Capabilities" } > > I feel that it is easier to read and parse. WDYT? I would prefer something more like that, but GN doesn't support maps. yzshen1 2016/04/06 16:00:47 Ah. That is a little unfortunate. Show quoted text On 2016/04/06 07:02:53, Sam McNally wrote: > On 2016/04/05 17:36:14, yzshen1 wrote: > > Does it make sense to use a map instead? Something like: > > > > type_mappings = { "gpu.mojom.Capabilities" : "gpu::Capabilities" } > > > > I feel that it is easier to read and parse. WDYT? > > I would prefer something more like that, but GN doesn't support maps. Ah. That is a little unfortunate.
OLD	NEW

« no previous file with comments | « gpu/command_buffer/common/BUILD.gn ('k') | gpu/command_buffer/common/command_buffer.typemap » ('j') | mojo/mojo_public.gyp » ('J')