Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Unified Diff: components/scheduler/renderer/renderer_scheduler_impl.h

Issue 1832673002: Add testRunner.runIdleTasks() to force idle tasks to run. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: add test Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/scheduler/renderer/renderer_scheduler_impl.h
diff --git a/components/scheduler/renderer/renderer_scheduler_impl.h b/components/scheduler/renderer/renderer_scheduler_impl.h
index 8805cb6d13b73fb3ccea164cfde85d699b738327..165c85e14d92e104024c1ea6575da8186f2b9899 100644
--- a/components/scheduler/renderer/renderer_scheduler_impl.h
+++ b/components/scheduler/renderer/renderer_scheduler_impl.h
@@ -106,6 +106,7 @@ class SCHEDULER_EXPORT RendererSchedulerImpl
TaskCostEstimator* GetTimerTaskCostEstimatorForTesting();
IdleTimeEstimator* GetIdleTimeEstimatorForTesting();
base::TimeTicks CurrentIdleTaskDeadlineForTesting() const;
+ void RunIdleTasksForTesting(const base::Closure&);
Sami 2016/04/06 15:52:37 nit: Please name the parameter (Chromium style doe
szager1 2016/04/06 17:55:30 Done.
base::TickClock* tick_clock() const;
@@ -184,6 +185,9 @@ class SCHEDULER_EXPORT RendererSchedulerImpl
void OnIdlePeriodEnded() override;
void EndIdlePeriod();
+ void EndIdlePeriodForTesting(
+ const base::Closure& callback,
+ base::TimeTicks time_remaining);
Sami 2016/04/06 15:52:37 Did you mean to remove this parameter? Also, the
szager1 2016/04/06 17:55:30 Because this is posted as an idle task, it has to
Sami 2016/04/06 18:01:58 Ah sorry, I wasn't paying attention while reading
// Returns the serialized scheduler state for tracing.
scoped_ptr<base::trace_event::ConvertableToTraceFormat> AsValue(
@@ -343,6 +347,7 @@ class SCHEDULER_EXPORT RendererSchedulerImpl
bool has_visible_render_widget_with_touch_handler;
bool begin_frame_not_expected_soon;
bool expensive_task_blocking_allowed;
+ bool in_idle_period_for_testing;
std::set<WebViewSchedulerImpl*> web_view_schedulers_; // Not owned.
};

Powered by Google App Engine
This is Rietveld 408576698