Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 1832663002: cc : Determine if a layer is root by using the value in LayerTreeImpl (Closed)

Created:
4 years, 9 months ago by jaydasika
Modified:
4 years, 9 months ago
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc : Determine if a layer is root by using the value in LayerTreeImpl This CL also makes ValidateRenderSurfaces in DrawPropertyUtils use Layer Iterator. BUG=594024, 568794 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/0c2fd47d62aba824e36bc78560f8c9d4288a30dd Cr-Commit-Position: refs/heads/master@{#383005}

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -47 lines) Patch
M cc/trees/draw_property_utils.cc View 9 chunks +25 lines, -14 lines 0 comments Download
M cc/trees/layer_tree_host_common.cc View 3 chunks +7 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 3 chunks +29 lines, -24 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_impl.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/layer_tree_impl.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M cc/trees/occlusion_tracker.cc View 5 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
jaydasika
PTAL
4 years, 9 months ago (2016-03-23 22:51:59 UTC) #3
ajuma
lgtm with a couple nits https://codereview.chromium.org/1832663002/diff/1/cc/trees/layer_tree_host_impl.cc File cc/trees/layer_tree_host_impl.cc (right): https://codereview.chromium.org/1832663002/diff/1/cc/trees/layer_tree_host_impl.cc#newcode812 cc/trees/layer_tree_host_impl.cc:812: render_surface_layer->layer_tree_impl()->IsRootLayer( You can directly ...
4 years, 9 months ago (2016-03-23 23:27:28 UTC) #4
jaydasika
https://codereview.chromium.org/1832663002/diff/1/cc/trees/layer_tree_host_impl.cc File cc/trees/layer_tree_host_impl.cc (right): https://codereview.chromium.org/1832663002/diff/1/cc/trees/layer_tree_host_impl.cc#newcode812 cc/trees/layer_tree_host_impl.cc:812: render_surface_layer->layer_tree_impl()->IsRootLayer( On 2016/03/23 23:27:28, ajuma wrote: > You can ...
4 years, 9 months ago (2016-03-24 00:14:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1832663002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1832663002/20001
4 years, 9 months ago (2016-03-24 00:15:03 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-24 01:26:14 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-24 01:28:08 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0c2fd47d62aba824e36bc78560f8c9d4288a30dd
Cr-Commit-Position: refs/heads/master@{#383005}

Powered by Google App Engine
This is Rietveld 408576698