cc : Determine if a layer is root by using the value in LayerTreeImpl

cc : Determine if a layer is root by using the value in LayerTreeImpl

This CL also makes ValidateRenderSurfaces in DrawPropertyUtils use
Layer Iterator.

BUG=594024, 568794
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/0c2fd47d62aba824e36bc78560f8c9d4288a30dd
Cr-Commit-Position: refs/heads/master@{#383005}

[jaydasika, 2016-03-23 22:49:38]

Description was changed from

==========
cc : Determine if a layer is root by using the value in LayerTreeImpl

This CL also makes ValidateRenderSurfaces in DrawPropertyUtils use
Layer Iterator.

BUG=594024,568794
==========

to

==========
cc : Determine if a layer is root by using the value in LayerTreeImpl

This CL also makes ValidateRenderSurfaces in DrawPropertyUtils use
Layer Iterator.

BUG=594024,568794
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[jaydasika, 2016-03-23 22:51:58]

jaydasika@chromium.org changed reviewers:
+ ajuma@chromium.org, vollick@chromium.org, weiliangc@chromium.org

[jaydasika, 2016-03-23 22:51:59]

PTAL

[ajuma, 2016-03-23 23:27:28]

lgtm with a couple nits

https://codereview.chromium.org/1832663002/diff/1/cc/trees/layer_tree_host_im...
File cc/trees/layer_tree_host_impl.cc (right):

https://codereview.chromium.org/1832663002/diff/1/cc/trees/layer_tree_host_im...
cc/trees/layer_tree_host_impl.cc:812:
render_surface_layer->layer_tree_impl()->IsRootLayer(
You can directly use active_tree_ here instead of
render_surface_layer->layer_tree_impl().

https://codereview.chromium.org/1832663002/diff/1/cc/trees/layer_tree_impl.h
File cc/trees/layer_tree_impl.h (right):

https://codereview.chromium.org/1832663002/diff/1/cc/trees/layer_tree_impl.h#...
cc/trees/layer_tree_impl.h:135: bool IsRootLayer(LayerImpl* layer) const;
Given that we have the version below that takes a const LayerImpl*, do we still
need this version that takes a non-const LayerImpl*?

[jaydasika, 2016-03-24 00:14:38]

https://codereview.chromium.org/1832663002/diff/1/cc/trees/layer_tree_host_im...
File cc/trees/layer_tree_host_impl.cc (right):

https://codereview.chromium.org/1832663002/diff/1/cc/trees/layer_tree_host_im...
cc/trees/layer_tree_host_impl.cc:812:
render_surface_layer->layer_tree_impl()->IsRootLayer(
On 2016/03/23 23:27:28, ajuma wrote:
> You can directly use active_tree_ here instead of
> render_surface_layer->layer_tree_impl().

Done.

https://codereview.chromium.org/1832663002/diff/1/cc/trees/layer_tree_impl.h
File cc/trees/layer_tree_impl.h (right):

https://codereview.chromium.org/1832663002/diff/1/cc/trees/layer_tree_impl.h#...
cc/trees/layer_tree_impl.h:135: bool IsRootLayer(LayerImpl* layer) const;
On 2016/03/23 23:27:28, ajuma wrote:
> Given that we have the version below that takes a const LayerImpl*, do we
still
> need this version that takes a non-const LayerImpl*?

Removed

[jaydasika, 2016-03-24 00:14:42]

The CQ bit was checked by jaydasika@chromium.org

[jaydasika, 2016-03-24 00:14:43]

The patchset sent to the CQ was uploaded after l-g-t-m from ajuma@chromium.org
Link to the patchset: https://codereview.chromium.org/1832663002/#ps20001
(title: " ")

[commit-bot: I haz the power, 2016-03-24 00:15:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1832663002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1832663002/20001

[commit-bot: I haz the power, 2016-03-24 01:26:14]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-24 01:28:07]

Description was changed from

==========
cc : Determine if a layer is root by using the value in LayerTreeImpl

This CL also makes ValidateRenderSurfaces in DrawPropertyUtils use
Layer Iterator.

BUG=594024,568794
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc : Determine if a layer is root by using the value in LayerTreeImpl

This CL also makes ValidateRenderSurfaces in DrawPropertyUtils use
Layer Iterator.

BUG=594024,568794
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/0c2fd47d62aba824e36bc78560f8c9d4288a30dd
Cr-Commit-Position: refs/heads/master@{#383005}
==========

[commit-bot: I haz the power, 2016-03-24 01:28:08]

Patchset 2 (id:??) landed as
https://crrev.com/0c2fd47d62aba824e36bc78560f8c9d4288a30dd
Cr-Commit-Position: refs/heads/master@{#383005}