Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1832643002: Allow Analysis Server crawl up the folders to search .analysis_options file. (Closed)

Created:
4 years, 9 months ago by scheglov
Modified:
4 years, 9 months ago
CC:
reviews_dartlang.org, lukeechurch_gmail.com
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Allow Analysis Server crawl up the folders to search .analysis_options file. R=brianwilkerson@google.com, jwren@google.com, pquitslund@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/d097a6e1cd975c78c12320e15caa9e3b9f4b2e76

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -70 lines) Patch
M pkg/analysis_server/lib/src/context_manager.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/source/analysis_options_provider.dart View 2 chunks +11 lines, -3 lines 1 comment Download
M pkg/analyzer/test/source/analysis_options_provider_test.dart View 4 chunks +119 lines, -63 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 9 months ago (2016-03-23 22:12:22 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/1832643002/diff/1/pkg/analyzer/lib/source/analysis_options_provider.dart File pkg/analyzer/lib/source/analysis_options_provider.dart (right): https://codereview.chromium.org/1832643002/diff/1/pkg/analyzer/lib/source/analysis_options_provider.dart#newcode27 pkg/analyzer/lib/source/analysis_options_provider.dart:27: var optionsSource = _readAnalysisOptionsFile(resource); type?
4 years, 9 months ago (2016-03-23 22:16:58 UTC) #2
scheglov
4 years, 9 months ago (2016-03-24 00:09:54 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
d097a6e1cd975c78c12320e15caa9e3b9f4b2e76 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698