tests/pnacl_dynamic_loading/nacl.scons - Issue 1832623002: PNaCl Dynamic Linking: Using unordered_set to disallow duplicate modules.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/pnacl_dynamic_loading/nacl.scons

Issue 1832623002: PNaCl Dynamic Linking: Using unordered_set to disallow duplicate modules. (Closed) Base URL: https://chromium.googlesource.com/native_client/src/native_client.git@master

Patch Set: Added AddBySoname/SetSonameSearchPaths, tested in pll_loader_test Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tests/pnacl_dynamic_loading/nacl.scons

diff --git a/tests/pnacl_dynamic_loading/nacl.scons b/tests/pnacl_dynamic_loading/nacl.scons

index e9826fefc06a3b32c929922b54cfa3c6a16ceedc..c6284b735e4ab5efece1089e7653e7178be293b7 100644

--- a/tests/pnacl_dynamic_loading/nacl.scons

+++ b/tests/pnacl_dynamic_loading/nacl.scons

@@ -112,9 +112,14 @@ pll_loader_test = env.ComponentProgram(

node = env.CommandSelLdrTestNacl(

'pll_loader_test.out', pll_loader_test,

- [test_pll_a, test_pll_b, test_pll_tls],

+ [Dir('.').abspath, 'test_pll_a.so', 'test_pll_b.so', 'test_pll_tls.so'],

# Add '-a' to enable filesystem access for opening DSOs.

sel_ldr_flags=['-a'])

+# Since we are passing sonames (rather than scons objects) to the

+# pll_loader_test, these dependencies must be made explicit.

+Depends(node, test_pll_a)

Mark Seaborn 2016/03/26 00:30:11 An alternative is: CommandSelLdrTestNacl(..., ext

Sean Klein 2016/03/26 00:47:25 Done.

+Depends(node, test_pll_b)

+Depends(node, test_pll_tls)

env.AddNodeToTestSuite(

node, ['small_tests', 'toolchain_tests'],

'run_pll_loader_test', is_broken=is_broken)

« src/untrusted/pll_loader/pll_loader.cc ('K') | « src/untrusted/pll_loader/pll_loader.cc ('k') | tests/pnacl_dynamic_loading/pll_loader_test.cc » ('j') | no next file with comments »